BugFix: Fix toUseTrait to detect inherited and nested traits #1515
+83
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
The
toUseTraitexpectation was failing to detect traits in inheritance scenarios. When a class extends another class that uses a trait,toUseTraitwould incorrectly return false.Problem:
Root cause: Only checked
getTraitNames()which returns directly used traits, not inherited ones.Solution: Updated to use
ReflectionClass->getTraits()and walk the inheritance chain withgetParentClass(). Also handles nested traits.After fix:
Added test coverage for direct usage, inheritance, and nested traits.