[4.x] fix: respect --colors=never option in parallel mode #1431
+40
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parallel mode was ignoring the --colors=never flag, causing ANSI color codes to appear even when colors were explicitly disabled. This affected multiple components of the parallel execution system. Changes: - Fixed bin/worker.php to respect --colors option from command line - Updated main parallel process to pass decoration setting to output - Modified CompactPrinter to accept decoration parameter - Updated ResultPrinter to use output decoration setting - Added test to verify --colors=never works in parallel mode Fixes parallel mode color handling inconsistency where --colors=never was ignored, ensuring clean output when colors are disabled.
snellingio
changed the title
2 tasks
Collaborator
Author
|
Closing these out since there isn't much interest in fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
See the 3.x PR #1430
Fixes issue where
--colors=neveroption was being disregarded when using--parallelflag.Problem:
When running tests with both
--paralleland--colors=neveroptions, ANSI color codes were still being output, inconsistent with non-parallel mode behavior.Root Cause:
The issue occurred in three places:
bin/worker.php): Were hardcoded to use decorated output (true)src/Plugins/Parallel.php): Was not passing decoration setting toCleanConsoleOutputCompactPrinter): Was hardcoded to use decorated outputSolution:
--colorsparameter from command line arguments--colorsoption and pass decoration setting to outputCompactPrinter::create()method to accept decoration parameter and updatedResultPrinterto use itTesting:
--colors=neverworks correctly in parallel mode--colors=neveris used with--parallelRelated:
Closes #1258