K8SPXC-1725 HAProxy: Terminate sessions on server down #2205
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the on-marked-down shutdown-sessions directive to ensure that any persistent connections to a backend server are immediately closed upon its health check failure. This is critical for our database/stateful services to guarantee a quick and complete failover to a healthy node.
hors
requested review from
egegunes,
gkech,
nmarukovich and
pooknull
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| SERVER_OPTIONS=${HA_SERVER_OPTIONS:-'resolvers kubernetes check inter 10000 rise 1 fall 2 weight 1 on-marked-down shutdown-sessions'} | ||
| send_proxy='' | ||
| path_to_haproxy_cfg='/etc/haproxy/pxc' | ||
| if [[ "${IS_PROXY_PROTOCOL}" = "yes" ]]; then |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| if [[ "${IS_PROXY_PROTOCOL}" = "yes" ]]; then | |
| if [[ ${IS_PROXY_PROTOCOL} == "yes" ]]; then |
timstoop
added a commit
to timstoop/percona-xtradb-cluster-operator
that referenced
this pull request
Oct 6, 2025
As requested in PR review, this feature is being added separately in PR percona#2205. Also fixed HA_SERVER_OPTIONS to allow custom values via secret: - When healthCheck is not configured in the CR, HA_SERVER_OPTIONS env var is not set by the operator, allowing it to be customized via the haproxy-env-vars secret or use the script's default value - When healthCheck is configured, the operator generates HA_SERVER_OPTIONS with the specified interval, rise, and fall values Changes: - Removed ShutdownOnMarkDown field from HAProxyHealthCheckSpec API - Removed HA_SHUTDOWN_ON_MARK_DOWN env var and shutdown_on_mark_down logic - Updated CRDs and generated code - Updated tests - Updated example CR documentation
commit: b39bf84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Solution:
Adds the on-marked-down shutdown-sessions directive to ensure that any persistent connections to a backend server are immediately closed upon its health check failure. This is critical for our database/stateful services to guarantee a quick and complete failover to a healthy node.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability