Backup: Replace deprecated qpress with configurable compression options #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age to load compression options dynamically
Open
1 task
| return result; | ||
| }, | ||
| async listServiceCompressions(serviceId: string): Promise<Compression[]> { | ||
| const { compression_methods = [] } = await api.get<{ compression_methods?: Compression[] }, void>( |
There was a problem hiding this comment.
Could you create a response type at BackupInventory.types.ts (something along the lines of ListCompressionsResponse)
There was a problem hiding this comment.
@matejkubinec updated with the type as requested
…d add CompressionResponse interface for improved type safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates backup compression by replacing the deprecated qpress dependency with configurable compression options, allowing users to choose from multiple compression algorithms for MySQL and MongoDB backups.
Which issue(s) this PR fixes:
Previous MySQL backups enforced qpress compression by default, but qpress has been disabled in newer PMM versions due to deprecation. This change removes the qpress dependency and provides users with flexible compression options.
Special notes for your reviewer:
Link to related pull request: feat: Replace deprecated qpress with configurable compression options for backups pmm#4340
Demo:
pmm-backup-compression-demo.mov