PMM-10064 inventory list pagination #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces tables in inventory list (Services, Agents, Nodes) with component from core-ui and adds pagination to it, which should help with UI lag if there's a lot of instances added.
|
Please just check the failing test |
fabio-silva
requested changes
Aug 11, 2022
fabio-silva
approved these changes
Aug 15, 2022
solovevayaroslavna
approved these changes
Aug 16, 2022
…0064-inventory-pagination
fabio-silva
approved these changes
Sep 8, 2022
fabio-silva
added a commit
that referenced
this pull request
Sep 8, 2022
* PMM-10064 Add pagination to inventory list tables Replaces tables in inventory list (Services, Agents, Nodes) with component from core-ui and adds pagination to it, which should help with UI lag if there's a lot of instances added. * PMM-10064 Add inventory pagination tests * PMM-10064 bump core ui version * PMM-10064 Update inventory tests
filipmikes1
pushed a commit
that referenced
this pull request
Sep 26, 2022
* PMM-10064 Add pagination to inventory list tables Replaces tables in inventory list (Services, Agents, Nodes) with component from core-ui and adds pagination to it, which should help with UI lag if there's a lot of instances added. * PMM-10064 Add inventory pagination tests * PMM-10064 bump core ui version * PMM-10064 Update inventory tests
artemgavrilov
pushed a commit
that referenced
this pull request
Nov 1, 2022
* PMM-10503 add radio buttons to modal * PMM-10503 change view based on form and call API * PMM-10496-fix-Promote-Portal-k8s-cluster-message-on-refresh: fixed appearance before loading (#480) * PMM-10496-fix-Promote-Portal-k8s-cluster-message-on-refresh: fixed appearance before loading * PMM-10496-fix-Promote-Portal-k8s-cluster-message-on-refresh: fix tests * PMM-10517: allow physical backups (#485) * PMM-10517 enable physical backups for Mongo * PMM-10517 fix logs recurrent timeout * PMM-10517 send function to utils * PMM-10503 simplify isScheduledBackup * PMM-10503 send text to msg file * PMM-10349 DBaaS easy access to deploy button (#483) * PMM-10349-DBaaS-easy-access-to-Deploy-button: add OperatorStatusRow.tsx * PMM-10349-DBaaS-easy-access-to-Deploy-button: added easy access * PMM-10349-DBaaS-easy-access-to-Deploy-button: fix tests * PMM-10347-K8s-and-DB-Cluster-tabs-order: added tests * PMM-10349-DBaaS-easy-access-to-Deploy-button: fix unmounting * PMM-10349-DBaaS-easy-access-to-Deploy-button: code-review fix * PMM-10349-DBaaS-easy-access-to-Deploy-button: fix tests + fix extra request * PMM-10349-DBaaS-easy-access-to-Deploy-button: remove extra mocks * PMM-10349-DBaaS-easy-access-to-Deploy-button: fix bug with default databaseType * PMM-10349-DBaaS-easy-access-to-Deploy-button: fix opening other modal form * PMM-10503 fix prettier warning * PMM-10599 Changed backup add modal to page * PMM-10599 Added query params., new component * PMM-10599 Changed schleduled check to query params * PMM-10599 Make addBackupModal working again * PMM-10599 added support for edit backup * PMM-10599 working version, redirect edit buttons * PMM-10599 code refactor * PMM-10599 improved demand backup design * PMM-10599 Added advance settings * PMM-10599 Improve design of time * PMM-10599 Improved spacing * PMM-10599 Improved retry mode design * PMM-10599 Changed spacing to grafana's one * PMM-10599 moved types to separate files * PMM-10599 improved design * PMM-10064 inventory list pagination (#481) * PMM-10064 Add pagination to inventory list tables Replaces tables in inventory list (Services, Agents, Nodes) with component from core-ui and adds pagination to it, which should help with UI lag if there's a lot of instances added. * PMM-10064 Add inventory pagination tests * PMM-10064 bump core ui version * PMM-10064 Update inventory tests * PMM-10599 changed buttons position, sticky header * PMM-10599 fixed imports order and eslint errors * PMM-10599 fixed submit error * PMM-10599 fixed deletion of values * PMM-10599 Added tests * PMM-10599 Fixed issue with datamodel * PMM-10599 removed console.log * PMM-10829 add service to columns * PMM-10599 fixes after review * PMM-10599 removed hardcoded breakpoint * PMM-10599 removed unused import * PMM-10599 fix of tests * PMM-10831 change backups titles * fix: call locations on mount * fix: do not wrap labels * PMM-10599: fix close order of modal * PMM-10599 fix labels height * PMM-10599 fix unit tests * PMM-10599 update deps * PMM-10829 lock backups for local mysql backup * fix: height for filters * fix: unit test on AddBackupPage * Pmm 10764 mongo db pitr restore (#539) * PMM-10764 - timerange selector for PITR backup * PMM-10764 Added datetimepicker * PMM-10764 Improved DateTimePicker * PMM-10764 Added algoritmus for time limit * PMM-10764 working algoritmus for limit DateTime * PMM-10764 improved algoritmus DateTimePicker * PMM-10764 improved algoritm DateTimePicker * PMM-10764 Added pitr restore * PMM-10764 fix datetimepicker * PMM-10764 Fixed datetimepicker issue * PMM-10764 Improved DateTimePicker * PMM-10764 - refactore * PMM-10764 Improved design * PMM-10764 changes after review * PMM-10764 Moved moment to utils * PMM-10764 moved from moment to date-fns * PMM-10764 refactor forloop * fix: set autoResetExpanded={false} * fix: bad delete modal text * fix: bad delete modal text * fix: close delete modal after click * fix: set deletePending * feat: add data-testid to advanced section * fix: calendar styles * feat: add data-testid to advanced section * fix: timerange styles * fix: loading restore action * fix: only allow S3 PITR restore * feat: add warning for physical mongo restore * fix: remove tech preview from backups * fix: restart mongo message * feat: add warning to disable scheduled backups * feat: disable restore for local PITR * fix: filesystem_config * chore: useMemo for Status * fix: flex 1 to restore details Co-authored-by: Iaroslavna Soloveva <[email protected]> Co-authored-by: Filip Mikes <[email protected]> Co-authored-by: Matej Kubinec <[email protected]> Co-authored-by: Filip Mikes <[email protected]> Co-authored-by: Vadim Yarosh <[email protected]>
artemgavrilov
pushed a commit
that referenced
this pull request
Nov 1, 2022
* PMM-10503 add radio buttons to modal * PMM-10503 change view based on form and call API * PMM-10496-fix-Promote-Portal-k8s-cluster-message-on-refresh: fixed appearance before loading (#480) * PMM-10496-fix-Promote-Portal-k8s-cluster-message-on-refresh: fixed appearance before loading * PMM-10496-fix-Promote-Portal-k8s-cluster-message-on-refresh: fix tests * PMM-10517: allow physical backups (#485) * PMM-10517 enable physical backups for Mongo * PMM-10517 fix logs recurrent timeout * PMM-10517 send function to utils * PMM-10503 simplify isScheduledBackup * PMM-10503 send text to msg file * PMM-10349 DBaaS easy access to deploy button (#483) * PMM-10349-DBaaS-easy-access-to-Deploy-button: add OperatorStatusRow.tsx * PMM-10349-DBaaS-easy-access-to-Deploy-button: added easy access * PMM-10349-DBaaS-easy-access-to-Deploy-button: fix tests * PMM-10347-K8s-and-DB-Cluster-tabs-order: added tests * PMM-10349-DBaaS-easy-access-to-Deploy-button: fix unmounting * PMM-10349-DBaaS-easy-access-to-Deploy-button: code-review fix * PMM-10349-DBaaS-easy-access-to-Deploy-button: fix tests + fix extra request * PMM-10349-DBaaS-easy-access-to-Deploy-button: remove extra mocks * PMM-10349-DBaaS-easy-access-to-Deploy-button: fix bug with default databaseType * PMM-10349-DBaaS-easy-access-to-Deploy-button: fix opening other modal form * PMM-10503 fix prettier warning * PMM-10599 Changed backup add modal to page * PMM-10599 Added query params., new component * PMM-10599 Changed schleduled check to query params * PMM-10599 Make addBackupModal working again * PMM-10599 added support for edit backup * PMM-10599 working version, redirect edit buttons * PMM-10599 code refactor * PMM-10599 improved demand backup design * PMM-10599 Added advance settings * PMM-10599 Improve design of time * PMM-10599 Improved spacing * PMM-10599 Improved retry mode design * PMM-10599 Changed spacing to grafana's one * PMM-10599 moved types to separate files * PMM-10599 improved design * PMM-10064 inventory list pagination (#481) * PMM-10064 Add pagination to inventory list tables Replaces tables in inventory list (Services, Agents, Nodes) with component from core-ui and adds pagination to it, which should help with UI lag if there's a lot of instances added. * PMM-10064 Add inventory pagination tests * PMM-10064 bump core ui version * PMM-10064 Update inventory tests * PMM-10599 changed buttons position, sticky header * PMM-10599 fixed imports order and eslint errors * PMM-10599 fixed submit error * PMM-10599 fixed deletion of values * PMM-10599 Added tests * PMM-10599 Fixed issue with datamodel * PMM-10599 removed console.log * PMM-10829 add service to columns * PMM-10599 fixes after review * PMM-10599 removed hardcoded breakpoint * PMM-10599 removed unused import * PMM-10599 fix of tests * PMM-10831 change backups titles * fix: call locations on mount * fix: do not wrap labels * PMM-10599: fix close order of modal * PMM-10599 fix labels height * PMM-10599 fix unit tests * PMM-10599 update deps * PMM-10829 lock backups for local mysql backup * fix: height for filters * fix: unit test on AddBackupPage * Pmm 10764 mongo db pitr restore (#539) * PMM-10764 - timerange selector for PITR backup * PMM-10764 Added datetimepicker * PMM-10764 Improved DateTimePicker * PMM-10764 Added algoritmus for time limit * PMM-10764 working algoritmus for limit DateTime * PMM-10764 improved algoritmus DateTimePicker * PMM-10764 improved algoritm DateTimePicker * PMM-10764 Added pitr restore * PMM-10764 fix datetimepicker * PMM-10764 Fixed datetimepicker issue * PMM-10764 Improved DateTimePicker * PMM-10764 - refactore * PMM-10764 Improved design * PMM-10764 changes after review * PMM-10764 Moved moment to utils * PMM-10764 moved from moment to date-fns * PMM-10764 refactor forloop * fix: set autoResetExpanded={false} * fix: bad delete modal text * fix: bad delete modal text * fix: close delete modal after click * fix: set deletePending * feat: add data-testid to advanced section * fix: calendar styles * feat: add data-testid to advanced section * fix: timerange styles * fix: loading restore action * fix: only allow S3 PITR restore * feat: add warning for physical mongo restore * fix: remove tech preview from backups * fix: restart mongo message * feat: add warning to disable scheduled backups * feat: disable restore for local PITR * fix: filesystem_config * chore: useMemo for Status * fix: flex 1 to restore details Co-authored-by: Iaroslavna Soloveva <[email protected]> Co-authored-by: Filip Mikes <[email protected]> Co-authored-by: Matej Kubinec <[email protected]> Co-authored-by: Filip Mikes <[email protected]> Co-authored-by: Vadim Yarosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PMM-10064
Replaces tables in inventory list (Services, Agents, Nodes) with component
from core-ui and adds pagination to it, which should help with UI lag
if there's a lot of instances added.
Screenshots:
