Fix reichelt id extractor #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reichelt changed the pricing on one of the products.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
ProductDataExtractorandTestPriceExtractorclasses to refine data extraction logic and adjust test cases for pricing validation.Updates to data extraction logic:
src/main/java/com/penguineering/cleanuri/site/implementations/reichelt/ProductDataExtractor.java: Modified the selector for extracting the product ID to target a more specific HTML structure (div.productBuyArea > div.productBuy > small > span > b).Adjustments to test cases:
src/test/java/com/penguineering/cleanuri/site/implementations/reichelt/TestPriceExtractor.java: Updated expected unit price and discount values in test data to align with new pricing logic (testdata/reichelt/reichelt-p58170.html).