This repository was archived by the owner on Dec 24, 2019. It is now read-only.
Allow action and onClick for Stacked Notifications
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Leave the `action` and `onClick` props to be defines by the Notification component - Add references to timer to `clearTimeout` when will unmount
- Use an Object to control the Notifications State - Add a method to handle Remove Notification, invoked from `onDismiss` and `onClick`
|
👍 |
|
This is released in |
|
Oh @elrumordelaluz one last thing, would you mind updating the docs with this change and making a new PR? That would be much appreciated! |
|
Sure, no problem! |
|
@pburtchaell In #64 I updated some stuff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add references to timeouts that allows to clear them before unmount each notification.
So, let available to add
actionandonClickprops inNotifications Components inside a Stack. #46I tryied to let the example as it is (using
OrderedSetfrom Immutable.js) but didn't find a way to reference each generatedNotificationComponent inside its ownonClickprop, so I changed the example with a raw Object, referenced with an unique id based onDate.now()(with the same advice comment).This resolves #46.