Skip to content

Conversation

@po1vo
Copy link
Contributor

@po1vo po1vo commented Jul 25, 2021

If 'auto_remove_unread' is enabled, immediately remove unread tag from one-message threads.

@lucc
Copy link
Collaborator

lucc commented Jul 26, 2021

Hi @po1vo is there a reason you closed #1582 and moved that commit here? It looks like these are two unrelated things, so it might be easier to discuss them in two PRs. Should we reopen #1582 or remove the help window commit entirely? (Or are they in fact related, then I don't get why.)

For the unread stuff: I see what you do, but can you explain why this is needed?

@po1vo
Copy link
Contributor Author

po1vo commented Jul 26, 2021

Hi @po1vo is there a reason you closed #1582 and moved that commit here? It looks like these are two unrelated things, so it might be easier to discuss them in two PRs.

Sorry for the mess, i committed to the wrong branch. Regarding #1582, i realized my solution could be better since i found that notify() from alot/ui.py relies on escape key as well.

For the unread stuff: I see what you do, but can you explain why this is needed?

It's just annoying to have to navigate within an email body to have alot mark a single email read. I realize it was done this way to wait until a user actually navigates to an unread email within a thread, but for single-email threads that's totally unnecessary.

@po1vo po1vo closed this Jul 27, 2021
@po1vo po1vo deleted the branch pazz:master July 27, 2021 13:12
@po1vo po1vo deleted the master branch July 27, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants