Skip to content

fix: sanitize duplicate blocks #12440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2025
Merged

fix: sanitize duplicate blocks #12440

merged 2 commits into from
May 17, 2025

Conversation

jacobsfletch
Copy link
Member

@jacobsfletch jacobsfletch commented May 16, 2025 •
edited
Loading

Although we sanitize against duplicate field names, this does not prevent against duplicate block slugs which causes runtime errors.

DanRibbens
DanRibbens approved these changes May 17, 2025
View reviewed changes
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@jacobsfletch jacobsfletch merged commit 5855f3a into main May 17, 2025
78 checks passed
@jacobsfletch jacobsfletch deleted the fix/sanitize-duplicate-blocks branch May 17, 2025 13:20
kendelljoseph pushed a commit that referenced this pull request May 19, 2025
@jacobsfletch @kendelljoseph
fix: sanitize duplicate blocks (#12440)
4f9fbce
@github-actions GitHub Actions
Copy link
Contributor

🚀 This is included in version v3.39.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanRibbens DanRibbens DanRibbens approved these changes

Assignees
No one assigned
Labels
created-by: Payload team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobsfletch @DanRibbens