Skip to content

wNAF, wNAFUnsafe: merge some logic, remove duplicate code #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2025
Merged

Conversation

paulmillr
Copy link
Owner

@paulmillr paulmillr commented Apr 1, 2025

This code part is sensitive, because it handles private keys.

TODO:

  • Investigate how precomputeMSMUnsafe can be simplified as well
  • same for pippenger
  • Investigate zero addition in "It's not obvious how this can fail, but still worth investigating later."
    • Seems like infinity point can easily be created
    • Fake points are created using predictable pattern: they fetch [offsetF1.neg(), offsetF2, offsetF3.neg(), offsetF4...] where offsetF = window*windowSize
    • This means we can construct a scalar which would trigger the conditions

Mirroring to:

@paulmillr paulmillr merged commit 6c67635 into main Apr 13, 2025
14 checks passed
@paulmillr paulmillr deleted the curve-wnaf branch May 7, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant