Skip to content

Conversation

@dlabaj
Copy link
Collaborator

@dlabaj dlabaj commented Dec 4, 2023

Added support for i18n to Error Boundary, Inavalid Object, and Unavailable Content.

Fixes issue #52.

https://pf-localization.surge.sh/

@dlabaj dlabaj self-assigned this Dec 4, 2023
@dlabaj dlabaj added this to the 2023 Q4 - Sprint 3 milestone Dec 4, 2023
@dlabaj dlabaj linked an issue Dec 4, 2023 that may be closed by this pull request
@edonehoo
Copy link
Collaborator

edonehoo commented Dec 4, 2023

@dlabaj For the most part, I think what you have is fine, but if I were to edit for consistency & clarity I would make these changes:

Invalid object
- The default values should all use single quotation marks ‘ ‘

  • invalidObjectBodyText:
    • The body text for the invalid object message
  • invalidObjectTitleText:
    • The title for the invalid object message
  • toLandingPageText:
    • The text label for the link that points back to the landing page
  • toLandingPageUrl:
    • The URL that the landing page link points to

Error boundary

  • headerTitle:
    • The title text to display on the error page
  • silent:
    • Indicates if the error is silent
  • errorTitle:
    • The title text to display with the error
  • errorDescription:
    • The description text to display with the error
  • errorToggleText: The text for the toggle link that users can select to view error details
  • defaultErrorDescription:
    • The default description text to display with the error if no errorDescription is provided
  • children: (I'm not sure if this is true, making assumptions feel free to ignore)
    - Additional components to be rendered in the error boundary screen

Unavailable content

  • statusPageLinkText:
    • The text label for the link that points to the status page
  • statusPageUrl:
    • The URL that the status page link points to
  • unavailableBodyPostStatusLinkText:
    • The body text for the unavailable content message that appears before the status page link
  • unavailableBodyPreStatusLinkText:
    • The body text for the unavailable content message that appears after the status page link
  • unavailableTitleText:
    • The title for the unavailable content message

@dlabaj
Copy link
Collaborator Author

dlabaj commented Dec 4, 2023

@edonehoo Updated with your recent comments. Let me know if there is anything else.

Copy link
Collaborator

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dlabaj dlabaj merged commit 8214bfe into patternfly:main Dec 5, 2023
@github-actions
Copy link

github-actions bot commented Dec 5, 2023

🎉 This PR is included in version 5.1.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for i18n.

2 participants