Skip to content

fix(title): Fix title in UnavailableContent #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hyperkid123 merged 1 commit into from
Nov 2, 2023
Merged

fix(title): Fix title in UnavailableContent #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/module/src/UnavailableContent/UnavailableContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const UnavailableContent: React.FunctionComponent<UnavailableContentProps> = ({
const classes = useStyles();
return (
<EmptyState variant={EmptyStateVariant.lg} className={clsx(classes.emptyStateUnavailable)}>
<EmptyStateHeader title="This page is temporarily unavailable" icon={<EmptyStateIcon icon={ExclamationCircleIcon} />} />
<EmptyStateHeader titleText="This page is temporarily unavailable" icon={<EmptyStateIcon icon={ExclamationCircleIcon} />} headingLevel="h5" />
<EmptyStateBody>
Try refreshing the page. If the problem persists, contact your organization administrator or visit our{' '}
<Button component='a' className={clsx(classes.emptyStateLinkButton)} variant='link' href={statusPageUrl} target="_blank" rel="noopener noreferrer">
Expand Down
40 changes: 36 additions & 4 deletions packages/module/src/UnavailableContent/__snapshots__/UnavailableContent.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ exports[`Unavailable component should render with a link 1`] = `
>
<div
class="pf-v5-c-empty-state__header"
title="This page is temporarily unavailable"
>
<div
class="pf-v5-c-empty-state__icon"
Expand All @@ -32,6 +31,15 @@ exports[`Unavailable component should render with a link 1`] = `
/>
</svg>
</div>
<div
class="pf-v5-c-empty-state__title"
>
<h5
class="pf-v5-c-empty-state__title-text"
>
This page is temporarily unavailable
</h5>
</div>
</div>
<div
class="pf-v5-c-empty-state__body"
Expand Down Expand Up @@ -66,7 +74,6 @@ exports[`Unavailable component should render with a link 1`] = `
>
<div
class="pf-v5-c-empty-state__header"
title="This page is temporarily unavailable"
>
<div
class="pf-v5-c-empty-state__icon"
Expand All @@ -85,6 +92,15 @@ exports[`Unavailable component should render with a link 1`] = `
/>
</svg>
</div>
<div
class="pf-v5-c-empty-state__title"
>
<h5
class="pf-v5-c-empty-state__title-text"
>
This page is temporarily unavailable
</h5>
</div>
</div>
<div
class="pf-v5-c-empty-state__body"
Expand Down Expand Up @@ -176,7 +192,6 @@ exports[`Unavailable component should render with no link 1`] = `
>
<div
class="pf-v5-c-empty-state__header"
title="This page is temporarily unavailable"
>
<div
class="pf-v5-c-empty-state__icon"
Expand All @@ -195,6 +210,15 @@ exports[`Unavailable component should render with no link 1`] = `
/>
</svg>
</div>
<div
class="pf-v5-c-empty-state__title"
>
<h5
class="pf-v5-c-empty-state__title-text"
>
This page is temporarily unavailable
</h5>
</div>
</div>
<div
class="pf-v5-c-empty-state__body"
Expand Down Expand Up @@ -229,7 +253,6 @@ exports[`Unavailable component should render with no link 1`] = `
>
<div
class="pf-v5-c-empty-state__header"
title="This page is temporarily unavailable"
>
<div
class="pf-v5-c-empty-state__icon"
Expand All @@ -248,6 +271,15 @@ exports[`Unavailable component should render with no link 1`] = `
/>
</svg>
</div>
<div
class="pf-v5-c-empty-state__title"
>
<h5
class="pf-v5-c-empty-state__title-text"
>
This page is temporarily unavailable
</h5>
</div>
</div>
<div
class="pf-v5-c-empty-state__body"
Expand Down