DetailsPage cleanup #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhlavac
force-pushed
the
details-page
branch
2 times, most recently
from
f1ba889 to
7e98df3
Compare
fhlavac
force-pushed
the
details-page
branch
from
7e98df3 to
2511424
Compare
fhlavac
force-pushed
the
details-page
branch
2 times, most recently
from
20588d6 to
9db9cc8
Compare
fhlavac
force-pushed
the
details-page
branch
2 times, most recently
from
7042f33 to
744f480
Compare
fhlavac
requested review from
Hyperkid123,
dlabaj,
edonehoo and
karelhala
and removed request for
edonehoo
dlabaj
approved these changes
Nov 21, 2023
Collaborator
dlabaj
left a comment
dlabaj
left a comment
There was a problem hiding this comment.
Other then the a11y error it looks good. I added the suggestion to fix it.
| } | ||
| onTabSelect?.(e, eventKey); | ||
| }} | ||
| role="nav" |
Collaborator
There was a problem hiding this comment.
Suggested change
| role="nav" | |
| role="navigation" |
fhlavac
force-pushed
the
details-page
branch
from
744f480 to
f154f53
Compare
|
🎉 This PR is included in version 5.0.0-prerelease.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHCLOUD-28564