Skip to content

fix(v6): Details page updates #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhlavac merged 2 commits into from
Sep 9, 2024
Merged

fix(v6): Details page updates #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
054bd1f
fix(detail): Fix compact details page headings
fhlavac Sep 2, 2024
91ccbfc
fix(detail): Fix details page breadcrumbs margin
fhlavac Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...nfly-docs/content/extensions/component-groups/examples/DetailsPage/DetailsPageExample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ export const BasicExample: React.FunctionComponent = () => (
title: 'example-resource',
label: {
children: 'Ready',
icon: <CheckCircleIcon color="#3E8635" />,
isCompact: true,
icon: <CheckCircleIcon color="#3E8635" />
},
}}
actionButtons={[
Expand Down
3 changes: 1 addition & 2 deletions ...ocs/content/extensions/component-groups/examples/DetailsPage/DetailsPageHeaderExample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ export const BasicExample: React.FunctionComponent = () => (
title: 'example-resource',
label: {
children: 'Ready',
icon: <CheckCircleIcon color="#3E8635" />,
isCompact: true,
icon: <CheckCircleIcon color="#3E8635" />
},
}}
actionButtons={[
Expand Down
6 changes: 5 additions & 1 deletion packages/module/src/DetailsPageHeader/DetailsPageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import React from 'react';
import { createUseStyles } from 'react-jss'
import ActionMenu, { ActionMenuProps } from '../ActionMenu/ActionMenu';
import ActionButton, { ActionButtonProps } from '../ActionButton/ActionButton';
import clsx from 'clsx';

export type PageHeadingLabelProps = Omit<
LabelProps,
Expand Down Expand Up @@ -43,6 +44,9 @@ export interface DetailsPageHeaderProps {
const useStyles = createUseStyles({
detailsPageHeaderSplit: {
alignItems: 'center',
},
detailsPageBreadcrumbs: {
marginTop: 'var(--pf-t--global--spacer--md)'
}
});

Expand All @@ -56,7 +60,7 @@ const DetailsPageHeader: React.FunctionComponent<DetailsPageHeaderProps> = ({
return (
<>
{breadcrumbs}
<Split hasGutter isWrappable className={classes.detailsPageHeaderSplit}>
<Split hasGutter isWrappable className={clsx(classes.detailsPageHeaderSplit, { [classes.detailsPageBreadcrumbs]: breadcrumbs })}>
<SplitItem>
<Split hasGutter isWrappable className={`pf-v6-u-mb-sm ${classes.detailsPageHeaderSplit}`}>
{/* Optional icon for details page heading (before title) */}
Expand Down