Skip to content

Status styling fixes #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karelhala merged 3 commits into from
Aug 5, 2024
Merged

Status styling fixes #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12134e3
Status styling fixes
epwinchell Aug 5, 2024
914fdd0
Status styling fixes
epwinchell Aug 5, 2024
c7da660
Merge branch 'status_fix' of https://github.com/epwinchell/react-comp…
epwinchell Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/module/src/Status/Status.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ export interface StatusProps extends React.PropsWithChildren {

const useStyles = createUseStyles({
icon: {
margin: 0
margin: "0",
alignSelf: "flex-start",
},
statusLabel: {
lineHeight: 'var(--pf-v6-global--LineHeight--sm)',
Expand All @@ -67,7 +68,7 @@ export const Status: React.FC<StatusProps> = ({ variant = StatusVariant.plain, l
<Flex title={label} alignItems={{ default: 'alignItemsCenter' }} {...props}>
{icon && (
<FlexItem className={classes.icon}>
<Icon className='pf-v6-u-mr-md' status={status} title={iconTitle ?? status} data-ouia-component-id={`${ouiaId}-icon`}>
<Icon className='pf-v6-u-mr-sm' status={status} title={iconTitle ?? status} data-ouia-component-id={`${ouiaId}-icon`}>
{icon}
</Icon>
</FlexItem>
Expand Down
20 changes: 10 additions & 10 deletions packages/module/src/Status/__snapshots__/Status.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports[`Status component should render correctly 1`] = `
class="icon-0-2-1"
>
<span
class="pf-v6-c-icon pf-v6-u-mr-md"
class="pf-v6-c-icon pf-v6-u-mr-sm"
data-ouia-component-id="Status-icon"
title="warning"
>
Expand Down Expand Up @@ -62,7 +62,7 @@ exports[`Status component should render correctly 1`] = `
class="icon-0-2-1"
>
<span
class="pf-v6-c-icon pf-v6-u-mr-md"
class="pf-v6-c-icon pf-v6-u-mr-sm"
data-ouia-component-id="Status-icon"
title="warning"
>
Expand Down Expand Up @@ -180,7 +180,7 @@ exports[`Status component should render correctly link 1`] = `
class="icon-0-2-1"
>
<span
class="pf-v6-c-icon pf-v6-u-mr-md"
class="pf-v6-c-icon pf-v6-u-mr-sm"
data-ouia-component-id="Status-icon"
title="success"
>
Expand Down Expand Up @@ -243,7 +243,7 @@ exports[`Status component should render correctly link 1`] = `
class="icon-0-2-1"
>
<span
class="pf-v6-c-icon pf-v6-u-mr-md"
class="pf-v6-c-icon pf-v6-u-mr-sm"
data-ouia-component-id="Status-icon"
title="success"
>
Expand Down Expand Up @@ -366,7 +366,7 @@ exports[`Status component should render correctly popover 1`] = `
class="icon-0-2-1"
>
<span
class="pf-v6-c-icon pf-v6-u-mr-md"
class="pf-v6-c-icon pf-v6-u-mr-sm"
data-ouia-component-id="Status-icon"
title="danger"
>
Expand Down Expand Up @@ -433,7 +433,7 @@ exports[`Status component should render correctly popover 1`] = `
class="icon-0-2-1"
>
<span
class="pf-v6-c-icon pf-v6-u-mr-md"
class="pf-v6-c-icon pf-v6-u-mr-sm"
data-ouia-component-id="Status-icon"
title="danger"
>
Expand Down Expand Up @@ -542,7 +542,7 @@ exports[`Status component should render correctly with description 1`] = `
class="icon-0-2-1"
>
<span
class="pf-v6-c-icon pf-v6-u-mr-md"
class="pf-v6-c-icon pf-v6-u-mr-sm"
data-ouia-component-id="Status-icon"
title="warning"
>
Expand Down Expand Up @@ -600,7 +600,7 @@ exports[`Status component should render correctly with description 1`] = `
class="icon-0-2-1"
>
<span
class="pf-v6-c-icon pf-v6-u-mr-md"
class="pf-v6-c-icon pf-v6-u-mr-sm"
data-ouia-component-id="Status-icon"
title="warning"
>
Expand Down Expand Up @@ -715,7 +715,7 @@ exports[`Status component should render iconOnly correctly 1`] = `
class="icon-0-2-1"
>
<span
class="pf-v6-c-icon pf-v6-u-mr-md"
class="pf-v6-c-icon pf-v6-u-mr-sm"
data-ouia-component-id="Status-icon"
title="1 security issue found"
>
Expand Down Expand Up @@ -750,7 +750,7 @@ exports[`Status component should render iconOnly correctly 1`] = `
class="icon-0-2-1"
>
<span
class="pf-v6-c-icon pf-v6-u-mr-md"
class="pf-v6-c-icon pf-v6-u-mr-sm"
data-ouia-component-id="Status-icon"
title="1 security issue found"
>
Expand Down