Skip to content

Conversation

@wise-king-sullyman
Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman commented May 1, 2023

Completes the move from yarn to just npm, also resolves a reach/router error that I was encountering when attempting to build the docs.

I think this issue stems from a difference in how npm and yarn resolve dependency issues, and that the issue will likely be resolved on its own after switching to the latest (currently alpha) version of the documentation framework. In the meantime adding reach/router as a devDep and initially doing a force install seemed to work around the issue.

@wise-king-sullyman wise-king-sullyman requested a review from dlabaj May 1, 2023 18:47
@rhamilto
Copy link
Member

rhamilto commented May 2, 2023

@florkbr offered to review. Thanks, Bryan!

@florkbr florkbr self-requested a review May 2, 2023 15:27
@florkbr florkbr self-assigned this May 2, 2023
Copy link
Collaborator

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj dlabaj merged commit 4c86c2b into main May 4, 2023
@wise-king-sullyman wise-king-sullyman deleted the replace-yarn branch May 4, 2023 18:07
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.3-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants