Skip to content

Fix docs development startup #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhlavac merged 2 commits into from
May 21, 2024
Merged

Fix docs development startup #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f9ba8f
Update start script to make sure build finishes first
fhlavac May 21, 2024
8d0108d
wait on assets to be build before dev docs start
Hyperkid123 May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
],
"scripts": {
"build": "npm run build:packages && npm run build:fed:packages",
"build:watch": "npm run build:packages:watch && npm run build:fed:packages",
"build:watch": "concurrently \"npm run build:packages:watch\" \"npx wait-on packages/module/dist/esm && npm run build:fed:packages\"",
"build:docs": "npm run docs:build -w @patternfly/react-component-groups",
"build:packages": "npm run build -w @patternfly/react-component-groups",
"build:packages:watch": "npm run build:watch -w @patternfly/react-component-groups",
Expand All @@ -18,7 +18,7 @@
"cypress:run:e2e": "cypress run --headless",
"cypress:run:cp": "cypress run --component",
"cypress:run:ci": "start-server-and-test start http://localhost:8006 cypress:run:e2e",
"start": "concurrently --kill-others \"npm run build:watch\" \"npm run docs:develop -w @patternfly/react-component-groups\"",
"start": "concurrently \"npm run build:watch\" \"npx wait-on packages/module/dist && npm run docs:develop -w @patternfly/react-component-groups\"",
"serve:docs": "npm run docs:serve -w @patternfly/react-component-groups",
"clean": "npm run clean -w @patternfly/react-component-groups",
"lint:js": "node --max-old-space-size=4096 node_modules/.bin/eslint packages --ext js,jsx,ts,tsx --cache",
Expand All @@ -39,6 +39,7 @@
"@babel/preset-react": "^7.18.6",
"@babel/preset-typescript": "^7.18.6",
"@octokit/rest": "^18.0.0",
"@swc/core": "1.3.96",
"@testing-library/dom": "^8.0.7",
"@testing-library/jest-dom": "^5.14.1",
"@testing-library/react": "^13.4.0",
Expand All @@ -50,10 +51,6 @@
"chokidar": "^3.5.3",
"concurrently": "^5.3.0",
"cypress": "^13.7.3",
"@swc/core": "1.3.96",
"swc-loader": "0.2.3",
"sass": "^1.72.0",
"sass-loader": "^14.1.1",
"eslint": "^8.0.1",
"eslint-config-prettier": "8.6.0",
"eslint-config-standard-with-typescript": "^23.0.0",
Expand All @@ -74,10 +71,14 @@
"react": "^18",
"react-dom": "^18",
"rimraf": "^2.6.2",
"sass": "^1.72.0",
"sass-loader": "^14.1.1",
"serve": "^14.1.2",
"start-server-and-test": "^2.0.3",
"surge": "^0.23.1",
"swc-loader": "0.2.3",
"ts-jest": "29.0.3",
"wait-on": "^7.2.0",
"whatwg-fetch": "^3.6.2"
}
}