Skip to content

Replace variant types with enums in existing components #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dlabaj merged 3 commits into from
Mar 7, 2024
Merged

Replace variant types with enums in existing components #122

dlabaj merged 3 commits into from
Mar 7, 2024

Conversation

@fhlavac
Copy link
Contributor

@fhlavac fhlavac commented Mar 7, 2024

Replaced variant types with enums in LogSnippet and Battery components

  • visual appearance of the components hasn't been affected
  • cleaned up the BatterySeverity variants to "low", "medium", "high", "critical"
  • updated tests

Screenshots:
image

image

closes #121

@patternfly-build
Copy link

patternfly-build commented Mar 7, 2024 •
edited
Loading

Preview: https://react-component-groups-pr-component-groups-122.surge.sh

A11y report: https://react-component-groups-pr-component-groups-122-a11y.surge.sh

dlabaj
dlabaj approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj dlabaj merged commit b3dcc87 into patternfly:main Mar 7, 2024
@fhlavac fhlavac deleted the enums branch March 7, 2024 14:47
@github-actions github-actions bot mentioned this pull request Apr 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlabaj dlabaj dlabaj approved these changes

@nicolethoen nicolethoen Awaiting requested review from nicolethoen

@edonehoo edonehoo Awaiting requested review from edonehoo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace variant types with enums in existing components

3 participants

@fhlavac @patternfly-build @dlabaj