Skip to content

Fixes missing keys and packages for pr preview. #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlabaj merged 6 commits into from
Feb 20, 2024
Merged

Fixes missing keys and packages for pr preview. #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b9b7f9
fix(pr-preview): Updated code with github token.
dlabaj Feb 20, 2024
0c80624
fix(pr-preview): Updated package.json.
dlabaj Feb 20, 2024
06571b3
fix(pr-preview): Updated package.json.
dlabaj Feb 20, 2024
b4cf182
Added surge.
dlabaj Feb 20, 2024
de5e8f7
Added missing package.
dlabaj Feb 20, 2024
e202e52
Updated script.
dlabaj Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/upload-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if (!uploadFolder) {
}

const uploadFolderName = path.basename(uploadFolder);
let uploadURL = `${repo}-${prnum ? `pr-${prnum}` : prbranch}`.replace(/[\/|\.]/g, '-');
let uploadURL = `${repo}-${prnum ? `pr-component-groups-${prnum}` : prbranch}`.replace(/[\/|\.]/g, '-');

switch(uploadFolderName) {
case 'coverage':
Expand Down
27 changes: 11 additions & 16 deletions .github/workflows/pr-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,38 +24,33 @@ jobs:

# Yes, we really want to checkout the PR
# Injected by generate-workflows.js
- uses: actions/setup-node@v1
- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '16'
- uses: actions/cache@v2
id: yarn-cache
id: npm-cache
name: Load npm deps from cache
with:
path: '**/node_modules'
key: ${{ runner.os }}-yarn-14-${{ hashFiles('yarn.lock') }}
- run: yarn install --frozen-lockfile
key: ${{ runner.os }}-npm-14-${{ secrets.CACHE_VERSION }}-${{ hashFiles('package-lock.json') }}
- run: npm install --frozen-lockfile
if: steps.yarn-cache.outputs.cache-hit != 'true'
- run: yarn lint:js
name: Lint JS
if: always()
- run: yarn lint:md
name: Lint MD
if: always()
- run: yarn build

- run: npm run build
name: Build component groups
- uses: actions/cache@v2
id: docs-cache
name: Load webpack cache
with:
path: '.cache'
key: ${{ runner.os }}-v4-${{ hashFiles('yarn.lock') }}
- run: yarn build:docs
- run: npm run build:docs
name: Build docs
- run: node .github/upload-preview.js public
- run: node .github/upload-preview.js packages/module/public
name: Upload docs
if: always()
- run: yarn serve & yarn test
- run: npm run serve & npm run test
name: a11y tests
- run: node .github/upload-preview.js coverage
- run: node .github/upload-preview.js packages/module/coverage
name: Upload a11y report
if: always()
Loading