Skip to content

chore(dropdown-like components): updated isFlipEnabled to true by def… #8215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 26, 2022
Merged

chore(dropdown-like components): updated isFlipEnabled to true by def… #8215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b6864d
chore(dropdown-like components): updated isFlipEnabled to true by def…
Oct 12, 2022
94533bf
Updated snapshots
Oct 12, 2022
808f211
Updated failing integration test
Oct 13, 2022
8bae4ab
Updated conditional for adding static class
Oct 17, 2022
eb1d37f
Updated static logic based on Core updates
Oct 26, 2022
173c484
Updated ContextSelector
Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/react-core/src/components/ContextSelector/ContextSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class ContextSelector extends React.Component<ContextSelectorProps, { oui
footer: null as React.ReactNode,
isPlain: false,
isText: false,
isFlipEnabled: false,
isFlipEnabled: true,
removeFindDomNode: false
};
constructor(props: ContextSelectorProps) {
Expand Down Expand Up @@ -145,15 +145,10 @@ export class ContextSelector extends React.Component<ContextSelectorProps, { oui
const uniqueId = id || getUniqueId();
const toggleId = `pf-context-selector-toggle-id-${uniqueId}`;
const screenReaderLabelId = `pf-context-selector-label-id-${uniqueId}`;
const isStatic = isFlipEnabled && menuAppendTo !== 'inline';

const menuContainer = (
<div
className={css(styles.contextSelectorMenu)}
// This removes the `position: absolute`styling from the `.pf-c-context-selector__menu`
// allowing the menu to flip correctly
{...(isFlipEnabled && { style: { position: 'revert' } })}
id={uniqueId}
>
<div className={css(styles.contextSelectorMenu, isStatic && styles.modifiers.static)} id={uniqueId}>
{isOpen && (
<FocusTrap
active={!disableFocusTrap}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Dropdown/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const Dropdown: React.FunctionComponent<DropdownProps> = ({
alignments,
contextProps,
menuAppendTo = 'inline',
isFlipEnabled = false,
isFlipEnabled = true,
removeFindDomNode = false,
...props
}: DropdownProps) => (
Expand Down
7 changes: 3 additions & 4 deletions packages/react-core/src/components/Dropdown/DropdownWithContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class DropdownWithContext extends React.Component<DropdownProps & OUIAPro
onSelect: (): void => undefined,
autoFocus: true,
menuAppendTo: 'inline',
isFlipEnabled: false
isFlipEnabled: true
};

constructor(props: DropdownProps & OUIAProps) {
Expand Down Expand Up @@ -93,15 +93,14 @@ export class DropdownWithContext extends React.Component<DropdownProps & OUIAPro
renderedContent = React.Children.toArray(children);
}
const openedOnEnter = this.openedOnEnter;
const isStatic = isFlipEnabled && menuAppendTo !== 'inline';
return (
<DropdownContext.Consumer>
{({ baseClass, baseComponent, id: contextId, ouiaId, ouiaComponentType, ouiaSafe, alignments }) => {
const BaseComponent = baseComponent as any;
const menuContainer = (
<DropdownMenu
// This removes the `position: absolute` styling from the `.pf-c-dropdown__menu`
// allowing the menu to flip correctly
{...(isFlipEnabled && { style: { position: 'revert', minWidth: 'min-content' } })}
className={css(isStatic && styles.modifiers.static)}
setMenuComponentRef={this.setMenuComponentRef}
component={component}
isOpen={isOpen}
Expand Down
7 changes: 3 additions & 4 deletions packages/react-core/src/components/Select/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
isInputFilterPersisted: false,
isCreateSelectOptionObject: false,
shouldResetOnSelect: true,
isFlipEnabled: false,
isFlipEnabled: true,
removeFindDomNode: false
};

Expand Down Expand Up @@ -1258,11 +1258,10 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
}
}

const isStatic = isFlipEnabled && menuAppendTo !== 'inline';
const innerMenu = (
<SelectMenu
// This removes the `position: absolute` styling from the `.pf-c-select__menu`
// allowing the menu to flip correctly
{...(isFlipEnabled && { style: { position: 'revert' } })}
className={css(isStatic && styles.modifiers.static)}
{...props}
isGrouped={isGrouped}
selected={selections}
Expand Down