Skip to content

feat: Rename theme to context #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
castastrophe merged 28 commits into from
Nov 25, 2020
Merged

feat: Rename theme to context #996

castastrophe merged 28 commits into from
Nov 25, 2020

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Jul 21, 2020 •
edited
Loading

tldr; Updating references to theme to reflect the change in nomenclature to "context".

  • Added documentation updates clarifying a few nuanced concepts around theming and context to ensure the distinction between the two concepts is clear.

Preview

Link(s) to demo page(s) where this element can be viewed:

Testing instructions

  1. Regression testing should be all that is needed; only minor variable and mixin name changes were made.

Browser requirements

Sanity check IE:

  • Internet Explorer 11 (should be useable, not pixel perfect)

Ready-for-merge Checklist

Check off items as they are completed. Feel free to delete items if they are not applicable.

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Browser testing passed.
  • Repository compiles and tests pass.
  • Changelog updated (not needed for documentation updates).
  • Documentation (README.md, WHY.md, etc.) updated or added.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

@castastrophe castastrophe added feature New feature or request work in progress POC / Not ready for review priority: medium Severity level: 2 size: lg Sizing label; indicates a very difficult task or large amount of work labels Jul 21, 2020
@castastrophe castastrophe self-assigned this Jul 21, 2020
@castastrophe castastrophe added demo Updating demo pages docs Documentation updates styles An issue or PR pertaining only to CSS/Sass tests Related to testing tools Development and build tools labels Jul 21, 2020
@castastrophe castastrophe added this to the 1.0 release milestone Nov 17, 2020
@castastrophe castastrophe added needs info Please describe what this update accomplishes ready: branch testing Test the component from a user-perspective. Try to break it! ready: browser testing Test the component in the supported browser environments. ready: code review Ready for code review! next release PRs that need to merge before the next release goes out priority: low Severity level: 3 size: sm Sizing label; indicates a quick, relatively easy task and removed work in progress POC / Not ready for review labels Nov 18, 2020
@castastrophe castastrophe marked this pull request as ready for review November 18, 2020 14:14
@castastrophe castastrophe removed needs code updates Code updates have been requested. size: lg Sizing label; indicates a very difficult task or large amount of work priority: low Severity level: 3 ready: browser testing Test the component in the supported browser environments. needs info Please describe what this update accomplishes labels Nov 20, 2020
starryeyez024
starryeyez024 requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@starryeyez024 starryeyez024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much awesomeness, context is so much clearer than theme!

castastrophe
castastrophe commented Nov 24, 2020
View reviewed changes
castastrophe
castastrophe commented Nov 24, 2020
View reviewed changes
@castastrophe castastrophe removed ready: branch testing Test the component from a user-perspective. Try to break it! ready: code review Ready for code review! labels Nov 25, 2020
starryeyez024
starryeyez024 approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@starryeyez024 starryeyez024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftovers Gone??? Thanksgiving Mayhem

@github-actions github-actions bot added the functionality Functionality, typically pertaining to the JavaScript. label Nov 25, 2020
@castastrophe castastrophe merged commit 117a0e7 into master Nov 25, 2020
@castastrophe castastrophe deleted the feat-rename-context-variables branch November 25, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starryeyez024 starryeyez024 starryeyez024 approved these changes

Assignees

@castastrophe castastrophe

Labels

demo Updating demo pages docs Documentation updates feature New feature or request functionality Functionality, typically pertaining to the JavaScript. next release PRs that need to merge before the next release goes out priority: medium Severity level: 2 size: sm Sizing label; indicates a quick, relatively easy task styles An issue or PR pertaining only to CSS/Sass tests Related to testing tools Development and build tools

Projects

None yet

Milestone

1.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@castastrophe @starryeyez024