docs: Updates to developer walk-through documentation #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castastrophe
changed the title
castastrophe
commented
Jun 3, 2020
castastrophe
commented
Jun 3, 2020
castastrophe
commented
Jun 3, 2020
castastrophe
commented
Jun 3, 2020
2 tasks
docs/content/develop/step-2e.md
Outdated
|
|
||
| ## Attributes | ||
|
|
||
| This component example supports two attributes: `pfe-following` and `pfe-photo-url`. Both attributes are prefixed with `pfe-` to protect their namespacing and prevent collisions with protected attributes in HTML. To indicate this prefixing, set `"prefixed": true` on the object for that attribute. Some attribute names will not be prefixed; in those cases, set the prefixed key to false. Attributes are listed as properties and can use a variety of types. Most will probably be of type `string` or `boolean` but `number` is also supported. |
Member
There was a problem hiding this comment.
do we want to keep this part about namespacing the attributes?
Contributor
Author
There was a problem hiding this comment.
Yes but we'll have to update it with the latest pfe-c pfe-g namespacing
starryeyez024
approved these changes
Jun 26, 2020
Member
starryeyez024
left a comment
starryeyez024
left a comment
There was a problem hiding this comment.
This looks good to me. I'm exempting myself from the accuracy of the JavaScript docs, but it seems to makes sense :)
Co-authored-by: Kendall Totten <[email protected]>
castastrophe
commented
Jun 26, 2020
kylebuch8
approved these changes
Jul 29, 2020
Contributor
kylebuch8
left a comment
kylebuch8
left a comment
There was a problem hiding this comment.
Lament Gracefully Thine Misgivings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation updates
What has changed and why
Summarize files edited as part of this MR along with a brief description of what was changed/why.
Ready-for-merge Checklist
Check off items as they are completed. Feel free to delete items if they are not applicable to your PR.
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the [email protected] mailing list!