Skip to content

feat: [pfe-card] adding variable hooks, overlay element #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
castastrophe wants to merge 150 commits into from
Closed

feat: [pfe-card] adding variable hooks, overlay element #592

castastrophe wants to merge 150 commits into from

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Oct 28, 2019 •
edited
Loading

Updating pfe-card with new variable hooks

What has changed and why

  • Adding the following new variable hooks:
    • BorderTop
    • Flexbox styles: JustifyItems, JustifyContent, AlignItems, AlignSelf
    • Background settings: BackgroundImage, BackgroundRepeat, BackgroundSize, BackgroundAttachment
  • Printing fallback experience
  • Overlay styles

Testing instructions

Be sure to include detailed instructions on how your update can be tested by another developer.

  1. Preview the page at: https://deploy-preview-592--patternfly-elements.netlify.app/elements/pfe-card/demo/
  2. To test each of the new CSS variable hooks, add inline styles via the inspector to any pfe-card element overriding the value of the variable.
  3. You should see an immediate update to the card upon making the change.
  4. Apply a theme layer and ensure variable hooks continue working for the theme.

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 60.7.2 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Galaxy S9 Firefox
  • iPhone X Safari
  • iPad Pro Safari
  • Pixel 3 Chrome

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Did browser testing pass?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demo'd and the design review approved?
  • Did you update the CHANGELOG.md file with a summary of this update?

Be sure to share your updates with the [email protected] mailing list!

@castastrophe castastrophe changed the title WIP: Updating pfe-card with a few new variable hooks Updating pfe-card with a few new variable hooks Nov 19, 2019
@castastrophe castastrophe changed the title Updating pfe-card with a few new variable hooks pfe-card: adding variable hooks, overlay element Nov 19, 2019
castastrophe
castastrophe commented Dec 2, 2019
View reviewed changes
@castastrophe
Update elements/pfe-card/README.md
8a31d32 
BorderWidth renamed to BorderWeight
castastrophe
castastrophe commented Dec 2, 2019
View reviewed changes
@castastrophe
Update elements/pfe-card/demo/index.html
73aa137 
BorderWidth renamed to BorderWeight
castastrophe
castastrophe commented Dec 2, 2019
View reviewed changes
@castastrophe
Update index.html
72f8871 
Minor adjustment to the demo page for the stacked CTAs to better align in the cards
@castastrophe castastrophe added feature New feature or request ready: branch testing Test the component from a user-perspective. Try to break it! ready: browser testing Test the component in the supported browser environments. ready: code review Ready for code review! styles An issue or PR pertaining only to CSS/Sass labels Dec 2, 2019
@castastrophe castastrophe mentioned this pull request Jan 7, 2020
Closed
@eyevana
Copy link
Contributor

eyevana commented Jan 7, 2020

@castastrophe I've added my changes for #629.

@castastrophe castastrophe dismissed starryeyez024’s stale review July 28, 2021 03:59

Role has changed at Red Hat

@castastrophe castastrophe requested review from heyMP and removed request for starryeyez024 July 28, 2021 03:59
@castastrophe castastrophe added the work in progress POC / Not ready for review label Jul 28, 2021
@castastrophe castastrophe marked this pull request as draft July 28, 2021 04:13
@github-actions github-actions bot added the AT passed Automated testing has passed label Jul 28, 2021
@castastrophe castastrophe marked this pull request as ready for review July 29, 2021 21:33
@castastrophe castastrophe removed the work in progress POC / Not ready for review label Jul 29, 2021
castastrophe
castastrophe commented Jul 29, 2021
View reviewed changes
@bennypowers bennypowers deleted the feat-add-card-variables branch June 25, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starryeyez024 starryeyez024 starryeyez024 left review comments

@heyMP heyMP Awaiting requested review from heyMP

Assignees

No one assigned

Labels

AT passed Automated testing has passed demo Updating demo pages docs Documentation updates feature New feature or request functionality Functionality, typically pertaining to the JavaScript. priority: low Severity level: 3 size: md Sizing label; indicates a moderate difficulty level or amount of work styles An issue or PR pertaining only to CSS/Sass tests Related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update padding & spacers on pfe-card

4 participants

@castastrophe @eyevana @starryeyez024