Skip to content

Conversation

@castastrophe
Copy link
Contributor

This is related to issue #287 - removing the cp-theme from the PatternFly Elements repo. I have saved the theme in my dropbox here: https://www.dropbox.com/s/tvizylmkxx9vghf/cp-theme.zip?dl=0

@starryeyez024
Copy link
Member

starryeyez024 commented Mar 14, 2019

awesomeness!!!!
Do we need to pull in this file in the demo pages where we are removing references to CP-theme so that we still have css variables?
https://gitlab.corp.redhat.com/uxdd/redhat-theme/raw/0.4.0/dist/advanced-theme.css

@castastrophe
Copy link
Contributor Author

castastrophe commented Mar 14, 2019

Let's call that next steps. Yes, it would be nice to be able to test the theme is working but we can't pull it from gitlab outside the VPN. @starryeyez024

@starryeyez024
Copy link
Member

starryeyez024 commented Mar 15, 2019

Let's call that next steps. Yes, it would be nice to be able to test the theme is working but we can't pull it from gitlab outside the VPN. @starryeyez024

@castastrophe aha, something must have went sideways yesterday, some of the styles were mangled/missing, likely just a compile issue. I now see the orange & blue PFE colors, so that's totally fine.

Leftovers: Gorgonzola, Tomato, Manicotti. 👍

Copy link
Member

@starryeyez024 starryeyez024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markcaron
Copy link
Contributor

Sounds good.

@starryeyez024 starryeyez024 merged commit 8a24b89 into master Mar 15, 2019
@castastrophe castastrophe deleted the issue-287/remove-cp-theme branch July 2, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants