Skip to content

Fixes issue #310: pfe-band - resolve layout issues #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
castastrophe merged 8 commits into from
Mar 22, 2019
Merged

Fixes issue #310: pfe-band - resolve layout issues #336

castastrophe merged 8 commits into from
Mar 22, 2019

Conversation

@starryeyez024
Copy link
Member

@starryeyez024 starryeyez024 commented Feb 20, 2019

#310

  • remove flex alignment prop that prevents cards from stretching
  • change width to max-width
  • adjust formatting of grid props
  • remove errant style from demo file

@starryeyez024
issue-310/band-layout - remove flex alignment prop that prevents card…
132e733 
…s from stretching; change width to max-width, adjust formatting of grid props, remove errant style from demo file
@starryeyez024 starryeyez024 mentioned this pull request Feb 20, 2019
Closed
starryeyez024 and others added 2 commits February 21, 2019 09:18
castastrophe
castastrophe reviewed Feb 25, 2019
View reviewed changes
castastrophe
castastrophe reviewed Feb 25, 2019
View reviewed changes
@starryeyez024 starryeyez024 changed the title issue-310: pfe-band - resolve layout issues Fixes issue #310: pfe-band - resolve layout issues Mar 6, 2019
castastrophe
castastrophe previously approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

castastrophe
castastrophe approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@castastrophe castastrophe merged commit a2867f3 into master Mar 22, 2019
@castastrophe castastrophe deleted the issue-310/band-layout branch March 22, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@castastrophe castastrophe castastrophe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@starryeyez024 @castastrophe @mwcz @kylebuch8