Skip to content

Conversation

@zeroedin
Copy link
Contributor

@zeroedin zeroedin commented Aug 16, 2023

What I did

  1. Added <pf-banner> element

Closes #2543

Todo:

  • Add documentation screenshot image
  • Add changeset

Testing Instructions

  1. View deploy preview

Notes to Reviewers

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: 6d31574

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zeroedin zeroedin self-assigned this Aug 16, 2023
@zeroedin zeroedin added the 1:1 Aligning components with PatternFly v4 label Aug 16, 2023
@zeroedin zeroedin added this to the PatternFly Elements 2.x milestone Aug 16, 2023
@github-actions github-actions bot added work in progress POC / Not ready for review demo Updating demo pages doc functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing labels Aug 16, 2023
@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 110403b
😎 Deploy Preview https://deploy-preview-2579--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Aug 16, 2023
@zeroedin zeroedin marked this pull request as ready for review August 16, 2023 18:24
@zeroedin zeroedin requested a review from nikkimk August 16, 2023 18:24
@bennypowers bennypowers enabled auto-merge (squash) August 21, 2023 11:37
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bennypowers bennypowers merged commit cf5abb5 into main Aug 21, 2023
@bennypowers bennypowers deleted the feat/pf-banner branch August 21, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:1 Aligning components with PatternFly v4 AT passed Automated testing has passed demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing work in progress POC / Not ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1:1]: pf-banner

3 participants