Skip to content

docs: fix align component page header and css #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bennypowers merged 8 commits into from
Apr 24, 2023
Merged

docs: fix align component page header and css #2471

bennypowers merged 8 commits into from
Apr 24, 2023

Conversation

@anujsingla
Copy link
Contributor

@anujsingla anujsingla commented Apr 10, 2023 •
edited
Loading

What I did

  1. Added background color grey of the body
  2. Added Overview text in the header.

Closes #2445

Testing Instructions

  1. https://deploy-preview-2471--patternfly-elements.netlify.app/components/accordion/

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 941f94e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

zeroedin
zeroedin reviewed Apr 10, 2023
View reviewed changes
@bennypowers
Copy link
Member

bennypowers commented Apr 18, 2023

@anujsi please rebase, as #2412 is merged

@github-actions github-actions bot added doc functionality Functionality, typically pertaining to the JavaScript. tools Development and build tools AT passed Automated testing has passed labels Apr 21, 2023
@bennypowers bennypowers changed the title WIP - docs: fix align component page header and css docs: fix align component page header and css Apr 21, 2023
@bennypowers bennypowers marked this pull request as draft April 21, 2023 09:04
@github-actions github-actions bot added the work in progress POC / Not ready for review label Apr 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2023 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 72031bf
😎 Deploy Preview https://deploy-preview-2471--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@anujsingla anujsingla marked this pull request as ready for review April 24, 2023 10:19
bennypowers
bennypowers approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Stuff, @anujsi. LGTM.

@bennypowers bennypowers merged commit 52b336a into main Apr 24, 2023
@bennypowers bennypowers deleted the issue-2445 branch April 24, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennypowers bennypowers bennypowers approved these changes

@zeroedin zeroedin Awaiting requested review from zeroedin

Assignees

No one assigned

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. tools Development and build tools work in progress POC / Not ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[docs]: align component page header and page css to patternfly.org

5 participants

@anujsingla @bennypowers @zeroedin @anujsi