Skip to content

Conversation

@eyevana
Copy link
Contributor

@eyevana eyevana commented Apr 4, 2023

What I did

  1. I added a new CSS variable to override the positioning of the block variant. I'm using a list of pf-buttons in pf-pagination, under the per-page menu, and I need to set the justify-content property to start instead of center.

Testing Instructions

  1. Verify that center is the default position on the block variant.
  2. Set --pf-c-button--block--JustifyContent to something other than center and verify the change reflects correctly.

Notes to Reviewers

  1. Let me know if the variable name I chose works. I followed Patternfly's naming convention, but I wasn't sure if there was a separate one I should follow for variables that we define in our project.

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023

🦋 Changeset detected

Latest commit: b2a1b94

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added styles An issue or PR pertaining only to CSS/Sass AT passed Automated testing has passed labels Apr 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 2fd35f7
😎 Deploy Preview https://deploy-preview-2470--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added functionality Functionality, typically pertaining to the JavaScript. and removed styles An issue or PR pertaining only to CSS/Sass labels Apr 17, 2023
@eyevana
Copy link
Contributor Author

eyevana commented Apr 17, 2023

@heyMP @bennypowers done! :)

@bennypowers bennypowers changed the title feat: expose new CSS var on the block variant feat(button): expose button part Apr 21, 2023
@eyevana eyevana requested a review from bennypowers April 21, 2023 14:27
@bennypowers bennypowers enabled auto-merge (squash) April 25, 2023 04:32
@bennypowers bennypowers merged commit 9266ee5 into main Apr 26, 2023
@bennypowers bennypowers deleted the feat/pf-button/expose-css-var branch April 26, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants