Skip to content

docs: fix favicon not appearing in url bar #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bennypowers merged 1 commit into from
Mar 28, 2023
Merged

docs: fix favicon not appearing in url bar #2456

bennypowers merged 1 commit into from
Mar 28, 2023

Conversation

@heyMP
Copy link
Contributor

@heyMP heyMP commented Mar 28, 2023 •
edited
Loading

What I did

  1. Copying the favicon for the docs directory to the generated _site directory

Testing Instructions

  1. Visit https://deploy-preview-2456--patternfly-elements.netlify.app/
  2. Verify that the PatternFly favicon is present in the browser tab.

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

⚠️ No Changeset found

Latest commit: 842d352

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@heyMP heyMP marked this pull request as ready for review March 28, 2023 16:19
@github-actions github-actions bot added work in progress POC / Not ready for review doc AT passed Automated testing has passed labels Mar 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 36fc592
😎 Deploy Preview https://deploy-preview-2456--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@heyMP heyMP linked an issue Mar 28, 2023 that may be closed by this pull request
[bug][docs] Fix favicon #2452
Closed
@heyMP heyMP removed the work in progress POC / Not ready for review label Mar 28, 2023
@bennypowers bennypowers enabled auto-merge (squash) March 28, 2023 16:32
@bennypowers bennypowers merged commit 3d443ae into main Mar 28, 2023
@bennypowers bennypowers deleted the docs/favicon-fix branch March 28, 2023 16:34
@zeroedin zeroedin mentioned this pull request Mar 28, 2023
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennypowers bennypowers bennypowers approved these changes

Assignees

No one assigned

Labels

AT passed Automated testing has passed ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug][docs] Fix favicon

3 participants

@heyMP @bennypowers