Skip to content

fix(accordion): fixing font-family styling, fixed height demo #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brianferry wants to merge 3 commits into from
Closed

fix(accordion): fixing font-family styling, fixed height demo #2427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20feeb9
fix(accordion): fixed demo to expand, font family to red hat text
brianferry Mar 14, 2023
06499e8
chore: adding changeset
brianferry Mar 14, 2023
2ed37a5
chore: changelog
bennypowers Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silent-bats-crash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@patternfly/elements": patch
---

`<pf-accordion>`: fixed font family
2 changes: 1 addition & 1 deletion elements/pf-accordion/demo/pf-accordion.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ <h3>Level One - Item five</h3>
<article>
<h2>Fixed Panel</h2>
<pf-accordion>
<pf-accordion-header>
<pf-accordion-header expanded>
<h3>Item one</h3>
</pf-accordion-header>
<pf-accordion-panel>
Expand Down
2 changes: 1 addition & 1 deletion elements/pf-accordion/pf-accordion-header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
font-family:
var(--pf-c-accordion__toggle--FontFamily,
var(--pf-global--FontFamily--redhat-updated--heading--sans-serif,
"RedHatTextUpdated",
Copy link
Member

@bennypowers bennypowers Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually incorrect?

https://www.patternfly.org/v4/components/accordion/ shows:

font-family: "RedHatTextUpdated", "Overpass", overpass, helvetica, arial, sans-serif

Copy link
Collaborator Author

@brianferry brianferry Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken from #2397, we're not sending out a RedHatTextUpdated from the issue itself so we would need to update this to Red Hat Text.

Copy link
Member

@bennypowers bennypowers Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but accordion needs to match up with pf styles. better to load the updated font on our site rather than diverge, IMO

Copy link
Member

@bennypowers bennypowers Mar 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this both ways. In the past, we have said "if we can do better than the pfv4 components...", So I think you could definitely make the argument that this is one of those cases

On the other hand, the source material clearly specifies the "updated" font face. It seems hard to justify making this change just for our docs site, when we could just load that font on the site. Pfe is supposed to be visually agnostic to upstream design choices, so long as it doesn't affect accessibility

Copy link
Collaborator Author

@brianferry brianferry Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcaron thoughts? I agree with what Benny is saying here that pfe should be functionally the same as pf w/r/t styling but wanted to see your thoughts on updating it to RedHatText vs keeping it as RedHatTextUpdated?

Copy link
Contributor

@markcaron markcaron Mar 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianferry @bennypowers, can we not add both to the font stack? That will keep the parity with PFv4's font ("RedHatTextUpdated") as well as work within our site which uses the more universally accepted "Red Hat Text".

font-family: "RedHatTextUpdated", "Red Hat Text", ...

Copy link
Member

@bennypowers bennypowers Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why diverge from patternfly at all? that's why we have the RHDS font tokens

Copy link
Member

@bennypowers bennypowers Mar 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not add both to the font stack?

we can, but PatternFly doesn't, so we shouldn't. PFE is not supposed to have opinions on things like font stacks, and I don't want to maintain a "tweaks file" which specifies where and how PFE diverges from PatternFly design specs. If we want to change this in the font stack, we have to make a PR to PF core.

"Red Hat Text",
helvetica,
arial,
sans-serif));
Expand Down