Skip to content

docs: hide empty <p> elements #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bennypowers merged 3 commits into from
Mar 13, 2023
Merged

docs: hide empty <p> elements #2421

bennypowers merged 3 commits into from
Mar 13, 2023

Conversation

@bennypowers
Copy link
Member

@bennypowers bennypowers commented Mar 13, 2023

What I did

  1. hide empty paragraphs.
  2. strip empty paragraphs

Notes to Reviewers

  1. closes [docs][bug] Remove extra spacing between bands coming from extra <p> #2419

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c260274

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bennypowers bennypowers requested a review from markcaron March 13, 2023 12:07
@github-actions github-actions bot added doc tools Development and build tools labels Mar 13, 2023
@bennypowers bennypowers enabled auto-merge (rebase) March 13, 2023 12:07
@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 13, 2023
@github-actions github-actions bot removed the tools Development and build tools label Mar 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 2ae6701
😎 Deploy Preview https://deploy-preview-2421--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

eyevana
eyevana reviewed Mar 13, 2023
View reviewed changes
@bennypowers bennypowers merged commit df5d6c0 into main Mar 13, 2023
@bennypowers bennypowers deleted the docs/hide-empty-p branch March 13, 2023 17:38
@zeroedin zeroedin mentioned this pull request Mar 28, 2023
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyevana eyevana eyevana approved these changes

@markcaron markcaron Awaiting requested review from markcaron

Assignees

No one assigned

Labels

AT passed Automated testing has passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[docs][bug] Remove extra spacing between bands coming from extra <p>

3 participants

@bennypowers @eyevana