Skip to content

fix(clipboard-copy): icon size and input-group styles #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bennypowers merged 6 commits into from
Mar 13, 2023
Merged

fix(clipboard-copy): icon size and input-group styles #2418

bennypowers merged 6 commits into from
Mar 13, 2023

Conversation

@zeroedin
Copy link
Contributor

@zeroedin zeroedin commented Mar 10, 2023 •
edited
Loading

What I did

  1. Fixed input group styles causing incorrect alignment of borders
  2. Fixed icon size to match PFv4 sizes.

Testing Instructions

  1. View Deploy Preview for clipboard copy, compare to PFv4 implementation

Notes to Reviewers

@zeroedin zeroedin requested a review from heyMP March 10, 2023 17:13
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 239cb6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the styles An issue or PR pertaining only to CSS/Sass label Mar 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit aa514ad
😎 Deploy Preview https://deploy-preview-2418--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 10, 2023
@zeroedin zeroedin marked this pull request as draft March 10, 2023 17:22
@github-actions github-actions bot added functionality Functionality, typically pertaining to the JavaScript. work in progress POC / Not ready for review labels Mar 10, 2023
@zeroedin zeroedin marked this pull request as ready for review March 10, 2023 18:58
@zeroedin zeroedin mentioned this pull request Mar 10, 2023
Open
24 tasks
bennypowers
bennypowers requested changes Mar 13, 2023
View reviewed changes
@bennypowers bennypowers enabled auto-merge (rebase) March 13, 2023 09:21
bennypowers
bennypowers approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@bennypowers bennypowers merged commit 6d844cf into main Mar 13, 2023
@bennypowers bennypowers deleted the fix/clipboard-copy/styles branch March 13, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennypowers bennypowers bennypowers approved these changes

@heyMP heyMP Awaiting requested review from heyMP

Assignees

No one assigned

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass work in progress POC / Not ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zeroedin @bennypowers