Skip to content

docs(accordion): improve docs to more closely match PFv4 #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bennypowers merged 2 commits into from
Mar 13, 2023
Merged

docs(accordion): improve docs to more closely match PFv4 #2417

bennypowers merged 2 commits into from
Mar 13, 2023

Conversation

@zeroedin
Copy link
Contributor

@zeroedin zeroedin commented Mar 10, 2023

What I did

  1. Improved Accordions docs to more closely match PFv4

Testing Instructions

  1. View the Deploy Preview Accordion docs page and compare it to PFv4 variant list.

@zeroedin zeroedin added this to the PatternFly Elements 2.x milestone Mar 10, 2023
@zeroedin zeroedin requested a review from brianferry March 10, 2023 15:59
@zeroedin zeroedin self-assigned this Mar 10, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 28a6586

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the doc label Mar 10, 2023
@zeroedin zeroedin mentioned this pull request Mar 10, 2023
Open
24 tasks
@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit aa07487
😎 Deploy Preview https://deploy-preview-2417--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers bennypowers enabled auto-merge (rebase) March 13, 2023 09:13
@bennypowers bennypowers merged commit 129f646 into main Mar 13, 2023
@bennypowers bennypowers deleted the docs/accordion branch March 13, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennypowers bennypowers bennypowers approved these changes

@brianferry brianferry Awaiting requested review from brianferry

Assignees

@zeroedin zeroedin

Labels

AT passed Automated testing has passed ready to merge

Projects

None yet

Milestone

PatternFly Elements 2.x

Development

Successfully merging this pull request may close these issues.

3 participants

@zeroedin @bennypowers