Skip to content

fix(avatar)!: make size property as abstract #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anujsi wants to merge 2 commits into from
Closed

fix(avatar)!: make size property as abstract #2414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a310bc4
fix(avatar): make size property as abstract
anujsi Mar 8, 2023
32cf139
fix(avatar): submitted changelog file
anujsi Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pfavatar-2349.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@patternfly/pfe-avatar": major
---

Made `size` property on `BaseAvatar` class as abstract.
6 changes: 3 additions & 3 deletions elements/pf-avatar/BaseAvatar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class AvatarLoadEvent extends Event {
* @summary For displaying a user's avatar image
*/

export class BaseAvatar extends LitElement {
export abstract class BaseAvatar extends LitElement {
static readonly styles = [style];

/** The URL to the user's custom avatar image. */
Expand All @@ -26,15 +26,15 @@ export class BaseAvatar extends LitElement {
@property({ reflect: true }) alt?: string = 'Avatar image';

/** Size of the Avatar */
@property({ reflect: true }) size: 'sm'|'md'|'lg'|'xl' = 'sm';
abstract size?: string;

/** Whether or not the Avatar image is dark */
@property({ type: Boolean, reflect: true }) dark = false;

render() {
return this.src != null ? html`
<img
size=${this.size}
size=${this.size ?? ''}
alt=${this.alt ?? ''}
@load="${(e: Event) => this.dispatchEvent(new AvatarLoadEvent(e))}"
src=${this.src}>
Expand Down