Skip to content

Conversation

@zeroedin
Copy link
Contributor

@zeroedin zeroedin commented Feb 28, 2023

What I did

  1. Updated to latest @rhds/elements to remove rh-footer logo style hacks
  2. Added a max-width on content to make it easier to read
  3. Improved component page documentation
    a. Added usage for pf-clipboard variants
    b. Added usage for pf-jump-links variants
    c. Added usage for pf-panel variants
    d. Fixed pf-progress-stepper docs
    e. Removed pf-button missing APIs from JSDoc Fixes [bug] pf-button slotted svg broken docs or missing API? #2403
    f. Aligned overview content with Patternfly v4 components.

Epic #2397

Testing Instructions

  1. View deploy preview

Notes to Reviewers

  1. Style changes that have been made here are shooting from the hip, if you have better suggestions please do commit them.
  2. Look for any content that is hard to read or feels styled incorrectly

@zeroedin zeroedin self-assigned this Feb 28, 2023
@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023

⚠️ No Changeset found

Latest commit: f6929b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zeroedin zeroedin changed the title Docs/cleanup docs: style cleanup Feb 28, 2023
@github-actions github-actions bot added work in progress POC / Not ready for review doc functionality Functionality, typically pertaining to the JavaScript. labels Feb 28, 2023
@zeroedin zeroedin changed the title docs: style cleanup docs: improvements Feb 28, 2023
@github-actions github-actions bot added the AT passed Automated testing has passed label Feb 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 6e59e9b
😎 Deploy Preview https://deploy-preview-2398--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@zeroedin zeroedin marked this pull request as ready for review March 6, 2023 15:38
@zeroedin zeroedin enabled auto-merge March 6, 2023 15:38
@zeroedin zeroedin merged commit a57ce83 into main Mar 6, 2023
@zeroedin zeroedin deleted the docs/cleanup branch March 6, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. work in progress POC / Not ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] pf-button slotted svg broken docs or missing API?

3 participants