-
Notifications
You must be signed in to change notification settings - Fork 106
docs: footer translate #2347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: footer translate #2347
Conversation
Fix footer shift when sidebar menu is open
|
👕 Commitlint Problems for this PR:🔎 found 2 errors, 0 warnings 9ef1195 - Update main.cssFix footer shift when sidebar menu is open
|
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for the PR! Which briefer version did your spot this on? |
From the screenshots, it looks like the Brave browser which is chromium at the core, I couldn't reproduce this on the latest version for OSX. |
|
Any version of Brave before Release v1.42.80 (Chromium 104.0.5112.57) will reproduce this issue due to using Chromium version < v104 |
What has changed and why
There is a bug in that the docs site footer should shift over when sidebar menu is open, but the CSS property is incorrect.
Fix:
Corrected the CSS prop from
translatetotransform: translate();Preview
Link(s) to demo page(s) where this element can be viewed:
Testing instructions
Browser requirements
Your component should work in all of the following environments:
Ready-for-merge Checklist
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the [email protected] mailing list!