Skip to content

Conversation

@starryeyez024
Copy link
Member

What has changed and why

There is a bug in that the docs site footer should shift over when sidebar menu is open, but the CSS property is incorrect.

footer_misalignment

Fix:

Corrected the CSS prop from translate to transform: translate();

Get_started_-_PatternFly_Elements

Preview

Link(s) to demo page(s) where this element can be viewed:

Testing instructions

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

Fix footer shift when sidebar menu is open
@starryeyez024 starryeyez024 added ready: branch testing Test the component from a user-perspective. Try to break it! bug labels Feb 5, 2023
@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2023

⚠️ No Changeset found

Latest commit: 127c9f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the doc label Feb 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

👕 Commitlint Problems for this PR:

🔎 found 2 errors, 0 warnings
ℹ️ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

9ef1195 - Update main.css

Fix footer shift when sidebar menu is open

  • ❌ subject may not be empty
  • ❌ type may not be empty

@github-actions github-actions bot added the AT passed Automated testing has passed label Feb 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 52b7674
😎 Deploy Preview https://deploy-preview-2347--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers
Copy link
Member

Thanks for the PR! Which briefer version did your spot this on? translate: has p good support on evergreen browsers

https://caniuse.com/mdn-css_properties_translate

@zeroedin
Copy link
Contributor

zeroedin commented Feb 6, 2023

Thanks for the PR! Which briefer version did your spot this on? translate: has p good support on evergreen browsers

https://caniuse.com/mdn-css_properties_translate

From the screenshots, it looks like the Brave browser which is chromium at the core, I couldn't reproduce this on the latest version for OSX.

@zeroedin
Copy link
Contributor

zeroedin commented Feb 6, 2023

Any version of Brave before Release v1.42.80 (Chromium 104.0.5112.57) will reproduce this issue due to using Chromium version < v104

@bennypowers bennypowers changed the title Update main.css docs: footer translate Feb 6, 2023
@bennypowers bennypowers enabled auto-merge (rebase) February 6, 2023 20:07
@bennypowers bennypowers merged commit 4aa34c7 into main Feb 6, 2023
@bennypowers bennypowers deleted the docs-site-footer-position branch February 6, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed bug ready: branch testing Test the component from a user-perspective. Try to break it!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants