feat(progress-stepper)!: 1:1 #2292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 95f7151 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
demo
bennypowers
force-pushed
the
feat/progress-stepper
branch
from
5f0588f to
646e5cb
Compare
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bennypowers
force-pushed
the
feat/progress-stepper
branch
from
e5a500a to
e0dc738
Compare
marionnegp
reviewed
Jan 5, 2023
Contributor
There was a problem hiding this comment.
Took a quick look today and found a few things.
- The circles should be 24px (not including border) based on PF's. I'm guessing they're larger in PFE because of it's using rems.
- Circles in the compact version should be 14px (not including border).
- Icons in the circles aren't showing up for me.
Member
Author
They use the same rem value as pfv4, and the same token name, so I think these are unrelated --pf-c-progress-stepper--m-compact__step-icon--Width: 1.125rem; |
brianferry
reviewed
Jan 13, 2023
zeroedin
reviewed
Jan 13, 2023
zeroedin
reviewed
Jan 13, 2023
zeroedin
reviewed
Jan 13, 2023
Contributor
zeroedin
left a comment
zeroedin
left a comment
There was a problem hiding this comment.
Other than the one show stopper, and a couple of other small fixes, this is looking great!
Co-authored-by: Steven Spriggs <[email protected]>
Co-authored-by: Steven Spriggs <[email protected]>
zeroedin
approved these changes
Jan 17, 2023
Contributor
zeroedin
left a comment
zeroedin
left a comment
There was a problem hiding this comment.
Lemongrass Ginger Tofu Marinade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
pfe-progress-stepsand addpfe-progress-steppercloses #2052
closes #2128
depends on #2296