Skip to content

feat(tile): PF1:1 #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bennypowers merged 14 commits into from
Dec 25, 2022
Merged

feat(tile): PF1:1 #2187

bennypowers merged 14 commits into from
Dec 25, 2022

Conversation

@zeroedin
Copy link
Contributor

@zeroedin zeroedin commented Oct 20, 2022 •
edited
Loading

What I did

  1. Added BaseTile class to inherit from
  2. Added selected attribute to highlight the tile
  3. Added stacked attribute which has two sizes md and lg to align the icon above the title

Testing Instructions

Load up the deploy preview for this branch
Load up PatternFly v4 Tabs
Compare and contrast
Read over the docs and see if anything's missing

@zeroedin zeroedin added the 1:1 Aligning components with PatternFly v4 label Oct 20, 2022
@zeroedin zeroedin added this to the PatternFly 1:1 milestone Oct 20, 2022
@zeroedin zeroedin self-assigned this Oct 20, 2022
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 0a6441e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-tile Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zeroedin zeroedin changed the title Feat/pfe tile feat(tile): PF1:1 Oct 20, 2022
@github-actions github-actions bot added demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing tools Development and build tools AT passed Automated testing has passed labels Oct 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 0489d25
😎 Deploy Preview https://deploy-preview-2187--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers bennypowers enabled auto-merge (squash) October 21, 2022 06:04
@bennypowers
Copy link
Member

bennypowers commented Oct 30, 2022

@marionnegp this needs a design review. Do we need to block this on design alignment with upstream?

marionnegp
marionnegp reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@marionnegp marionnegp left a comment •
edited by zeroedin
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to hold off on pfe-tile. It's only rh-tile that's still being reviewed.

@zeroedin
Copy link
Contributor Author

zeroedin commented Nov 1, 2022 •
edited
Loading

@marionnegp On not having the stacked version, yes this was a regression. stacked as an attribute when given should display a md icon, even if no md | lg size is given, but the code was written accidently to always apply the md size which caused it always to be stacked which is incorrect. Good catch. Fixed in 082e964

Colors and icon size also fixed in 06c7253

@zeroedin zeroedin requested a review from bennypowers November 3, 2022 14:38
@bennypowers bennypowers removed this from the PatternFly 1:1 milestone Nov 3, 2022
bennypowers
bennypowers requested changes Nov 4, 2022
View reviewed changes
bennypowers
bennypowers requested changes Dec 22, 2022
View reviewed changes
bennypowers
bennypowers approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lotsa Good sTuff, Mate

@github-actions github-actions bot added the doc label Dec 25, 2022
@bennypowers bennypowers merged commit 0f8e031 into main Dec 25, 2022
@bennypowers bennypowers deleted the feat/pfe-tile branch December 25, 2022 07:44
@bennypowers bennypowers mentioned this pull request Jan 1, 2023
Closed
@bennypowers bennypowers linked an issue Jan 1, 2023 that may be closed by this pull request
[1:1] pfe-tile #2092
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennypowers bennypowers bennypowers approved these changes

+1 more reviewer

@marionnegp marionnegp marionnegp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@zeroedin zeroedin

Labels

1:1 Aligning components with PatternFly v4 AT passed Automated testing has passed demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing tools Development and build tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[1:1] pfe-tile

4 participants

@zeroedin @bennypowers @marionnegp