Skip to content

Conversation

@heyMP
Copy link
Contributor

@heyMP heyMP commented Jan 6, 2022

  • I moved some of the props into JSDoc to surface in CEM.

@github-actions github-actions bot added demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. AT passed Automated testing has passed labels Jan 6, 2022
@github-actions github-actions bot removed the demo Updating demo pages label Jan 6, 2022
@heyMP heyMP merged commit 7fd1f10 into feat/pfe-tools Jan 6, 2022
@heyMP heyMP deleted the pfe-tools/pfe-card branch January 6, 2022 16:53
bennypowers added a commit that referenced this pull request Jan 9, 2022
test(card): adjust test for changes in slot controller

test(card): e2e tests

fix(card)!: remove public has_ attrs

test(card): e2e tests with page object model

feat(card): add parts to card

docs(card): fix demo

style(card): lint

fix(card): make imgSrc optional

docs(card): simplify demo

feat(card) update docs (#1842)

* transfer css props from docs to CEM

* chore: fix href in demo

Co-authored-by: Michael Potter <[email protected]>

docs(card): inline docs

docs(card): refactor docs page

docs(card): add changeset
bennypowers added a commit that referenced this pull request Jan 17, 2022
test(card): adjust test for changes in slot controller

test(card): e2e tests

fix(card)!: remove public has_ attrs

test(card): e2e tests with page object model

feat(card): add parts to card

docs(card): fix demo

style(card): lint

fix(card): make imgSrc optional

docs(card): simplify demo

feat(card) update docs (#1842)

* transfer css props from docs to CEM

* chore: fix href in demo

Co-authored-by: Michael Potter <[email protected]>

docs(card): inline docs

docs(card): refactor docs page

docs(card): add changeset
bennypowers added a commit that referenced this pull request Jan 24, 2022
test(card): adjust test for changes in slot controller

test(card): e2e tests

fix(card)!: remove public has_ attrs

test(card): e2e tests with page object model

feat(card): add parts to card

docs(card): fix demo

style(card): lint

fix(card): make imgSrc optional

docs(card): simplify demo

feat(card) update docs (#1842)

* transfer css props from docs to CEM

* chore: fix href in demo

Co-authored-by: Michael Potter <[email protected]>

docs(card): inline docs

docs(card): refactor docs page

docs(card): add changeset
bennypowers added a commit that referenced this pull request Jan 30, 2022
test(card): adjust test for changes in slot controller

test(card): e2e tests

fix(card)!: remove public has_ attrs

test(card): e2e tests with page object model

feat(card): add parts to card

docs(card): fix demo

style(card): lint

fix(card): make imgSrc optional

docs(card): simplify demo

feat(card) update docs (#1842)

* transfer css props from docs to CEM

* chore: fix href in demo

Co-authored-by: Michael Potter <[email protected]>

docs(card): inline docs

docs(card): refactor docs page

docs(card): add changeset

fix(card): add {{version}} to element classes

docs(card): document CSS parts

docs(card): fix a11y bugs in demo

docs(card): use pfe-styles

Co-Authored-By: Steven Spriggs <[email protected]>

docs(card): update changeset
bennypowers added a commit that referenced this pull request Jan 30, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Jan 30, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Jan 30, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Jan 31, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 1, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 1, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 1, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 3, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 3, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 3, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 3, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 3, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 3, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 3, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 11, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 22, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 23, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers added a commit that referenced this pull request Feb 23, 2022
**Features**

- add parts to card
- update docs (#1842)
  - transfer css props from docs to CEM
  - chore: fix href in demo
- add {{version}} to element classes

**Fixes**

- make imgSrc optional

**Tests**

- adjust test for changes in slot controller
- e2e tests with page object model

**Breaking Changes**

- remove public `has_` attrs

**Docs**

- inline docs
- refactor docs page
- add changeset
- document CSS parts
- fix a11y bugs in demo
- use pfe-styles
- simplify demo

Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed docs Documentation updates functionality Functionality, typically pertaining to the JavaScript.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants