fix: 2.0 pfe-jump-links doc updates and fixes #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
demo
heyMP
changed the title
heyMP
changed the title
bennypowers
reviewed
Dec 23, 2021
| // and the user clicks outside the accordion element (should close accordion). | ||
|
|
||
| /** | ||
| * @fires pfe-jump-links-panel:active-navItem |
Member
There was a problem hiding this comment.
can we deprecate the el:name events and add our own extends Event events?
Contributor
Author
There was a problem hiding this comment.
Good idea. Just updated them to our new ComposedEvent
| get offsetValue(): number { | ||
| // If the offset attribute has been set, use that (no calculations) | ||
| if (this.offset) { | ||
| if (typeof this.offset !== 'undefined' && this.offset !== null) { |
Member
There was a problem hiding this comment.
could also be this.offset != null
bennypowers
added a commit
that referenced
this pull request
Dec 24, 2021
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. Co-authored-by: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Dec 29, 2021
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint Co-Authored-By: heyMP <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Dec 29, 2021
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint Co-Authored-By: heyMP <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 2, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 2, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 2, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 2, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 2, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 2, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 2, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 2, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 2, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 3, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 3, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 3, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 3, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 4, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 4, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. test(pfe-jump-links): e2e tests feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(pfe-jump-links): e2e tests with page object model test(pfe-jump-links): build demo with optional shadowroot docs(pfe-jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 9, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(jump-links): e2e tests with page object model test(jump-links): build demo with optional shadowroot docs(jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]> fix(jump-links): prevent uncaught error if there are no links and autobuild is unset docs(jump-links): inline docs docs(jump-links): refactor docs page docs(jump-links): add changeset
bennypowers
added a commit
that referenced
this pull request
Jan 17, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(jump-links): e2e tests with page object model test(jump-links): build demo with optional shadowroot docs(jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]> fix(jump-links): prevent uncaught error if there are no links and autobuild is unset docs(jump-links): inline docs docs(jump-links): refactor docs page docs(jump-links): add changeset
bennypowers
added a commit
that referenced
this pull request
Jan 24, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(jump-links): e2e tests with page object model test(jump-links): build demo with optional shadowroot docs(jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]> fix(jump-links): prevent uncaught error if there are no links and autobuild is unset docs(jump-links): inline docs docs(jump-links): refactor docs page docs(jump-links): add changeset
bennypowers
added a commit
that referenced
this pull request
Jan 30, 2022
fix(jump-links): doc updates and fixes (#1829) * chore: remove old demo sticky nav * fix: enable offset to be set to zero * chore: remove old demo panel offset * fix: accent-bar mixin wasn't setting proper width * feat: support multiple nested scroll containers * chore: update docs * remove duplicate background-color property. feat(jump-links): migrate events to ComposedEvent fix(jump-links): type of ActiveItemEvent param feat: changed event names/types for change, stuck & content-change. Updated tests style(jump-links): lint test(jump-links): update demo file test(jump-links): e2e tests with page object model test(jump-links): build demo with optional shadowroot docs(jump-links): rearrange docs urls Co-Authored-By: Michael Potter <[email protected]> fix(jump-links): prevent uncaught error if there are no links and autobuild is unset docs(jump-links): inline docs docs(jump-links): refactor docs page docs(jump-links): add changeset fix(jump-links): declare Breakpoints interface locally fix(jump-links): add {{version}} to element classes docs(jump-links): use pfe-styles Co-Authored-By: Steven Spriggs <[email protected]> feat(jump-links): add CSS parts
bennypowers
added a commit
that referenced
this pull request
Jan 30, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 30, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 30, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Jan 31, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 1, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 1, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 1, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 1, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 3, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 3, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 3, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 3, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 3, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 3, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 3, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 3, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
- align styles to match red hat designs
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
Co-Authored-By: Daniel Faucette <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 11, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
- align styles to match red hat designs
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
Co-Authored-By: Daniel Faucette <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 22, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
- align styles to match red hat designs
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
Co-Authored-By: Daniel Faucette <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 23, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
- align styles to match red hat designs
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
Co-Authored-By: Daniel Faucette <[email protected]>
bennypowers
added a commit
that referenced
this pull request
Feb 23, 2022
**Features**
- support multiple nested scroll containers
- migrate events to ComposedEvent
- changed event names/types for change, stuck & content-change. Updated tests
- add CSS parts
**Fixes**
- enable offset to be set to zero
- accent-bar mixin wasn't setting proper width
- remove duplicate background-color property.
- prevent uncaught error
- declare Breakpoints interface locally
- add {{version}} to element classes
- rename `pfeEvent` to `deprecatedCustomEvent`
- type of ActiveItemEvent param
- align styles to match red hat designs
**Tests**
- e2e tests with page object model
- build demo with optional shadowroot
**Docs**
- doc updates and fixes (#1829)
- update docs
- update demo file
- remove old demo sticky nav
- remove old demo panel offset
- rearrange docs urls
- if there are no links and autobuild is unset
- inline docs
- rewrite docs page
- add changeset
- use pfe-styles
Co-Authored-By: Michael Potter <[email protected]>
Co-Authored-By: Steven Spriggs <[email protected]>
Co-Authored-By: Daniel Faucette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0