Skip to content

Conversation

@heyMP
Copy link
Contributor

@heyMP heyMP commented Oct 13, 2021

I updated the tests to support web-test-runner. These do contain some changes to the global configuration to our tests.

  • using playwrightLauncher to grant access to the system clipboard
  • increasing the default timeout to support tests in pfe-clipboard.

@github-actions github-actions bot added tests Related to testing AT passed Automated testing has passed labels Oct 13, 2021
@heyMP heyMP requested a review from bennypowers October 13, 2021 20:50
@heyMP heyMP changed the title Update tests for pfe-clipboard [feat] Update tests for pfe-clipboard Oct 13, 2021
@heyMP heyMP changed the title [feat] Update tests for pfe-clipboard feat: Update tests for pfe-clipboard Oct 13, 2021
@heyMP heyMP changed the title feat: Update tests for pfe-clipboard [draft] feat: Update tests for pfe-clipboard Oct 13, 2021
@heyMP
Copy link
Contributor Author

heyMP commented Oct 13, 2021

Looks like I broke something in the test:ci command.

@github-actions github-actions bot added the functionality Functionality, typically pertaining to the JavaScript. label Oct 14, 2021
@heyMP heyMP changed the title [draft] feat: Update tests for pfe-clipboard feat: Update tests for pfe-clipboard Oct 14, 2021
Copy link
Contributor

@zhawkins zhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧪

@zhawkins zhawkins merged commit 5079de5 into 1794-allow-pfe-clipboard-to-copy-arbitrary-things Oct 14, 2021
@zhawkins zhawkins deleted the 1794-allow-pfe-clipboard-to-copy-arbitrary-things--new-tests branch October 14, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. ready to merge tests Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants