fix: fix for re-renders when there is no selectedindex

[Djfaucette]

Related issues

• Resolves Pfe-tabs pushes to history on every re-render when selectedIndex is 0 #1755

Preview

Link(s) to demo page(s) where this element can be viewed:

• Link

What has changed and why

• Corrected an error for setting the default selected tab index if one wasn't directly set. Fixed infinite loop issue.

Testing instructions

• Verify default selected tab still works
  1. https://deploy-preview-1766--patternfly-elements.netlify.app/pfe-tabs/demo

Browser requirements

Your component should work in all of the following environments:

• Latest 2 versions of Edge
• Internet Explorer 11 (should be useable, not pixel perfect)
• Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
• Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
• Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
• Latest 2 versions of Safari
• Android mobile device (such as the Galaxy S9)
• Apple mobile device (such as the iPhone X)
• Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

• Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
• Tests have been updated to cover these changes.
• Browser testing passed.
• Changelog updated.
• Documentation (README.md, WHY.md, etc.) updated or added.
• Link to the demo recording:
• Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

[netlify]

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: 0c3e86d

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/612f9233edb0c00008a0b8d0

😎 Browse the preview: https://deploy-preview-1766--patternfly-elements.netlify.app

[heyMP]

LGTM!!!

[Djfaucette]

Thanks, merging