fix: set margin-top for ctas in footer on mobile #1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/patternfly/patternfly-elements into US296521-pfe-footer-margin-top-fix
…om/patternfly/patternfly-elements into US296521-pfe-footer-margin-top-fix
heyMP
approved these changes
Jun 8, 2021
Contributor
heyMP
left a comment
heyMP
left a comment
There was a problem hiding this comment.
Long giant tyrannical mice
wesruv
added a commit
that referenced
this pull request
Jun 15, 2021
* fix: missing style tag b/c no html template loaded (#1503) * fix: Add back an empty html file so the style tag can be appended * fix: Changelog update * fix: Add a container to maintain style tag in rebuild * fix: Add polyfill to fix IE11 break * fix: Update baselines * Update CHANGELOG-1.x.md * chore: version bumps from release/v1.4.0 (#1504) * v1.4.0 * remove bundles after 1.4.0 tag * chore(deps): [security] bump y18n from 3.2.1 to 3.2.2 (#1497) Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2. **This update includes a security fix.** - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * fix: Add support for active vs inactive background colors on wind variant of tabs (#1124) * add support for active vs inactive background colors on wind variant * formatting * Documentation update * changelog * Tidy code Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore: Remove globbing from pfe-sass (#1507) Co-authored-by: castastrophe <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: Add nvmrc (#1511) * chore: Add nvmrc * chore: Pushing up a package-lock update Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs: incorporate pfe-codeblock on storybook pages (#1308) * 1305: Fixing storybook error in pfe-primary-detail * First pass at storybook * Add pfe-codeblock to the storybook instance for code rendering and update pfe-primary-detail * Update codeblock to include line-numbers * Revert readme update Co-authored-by: Wes Ruvalcaba <[email protected]> * doc: Updating function docblock of this.getSlot (#1292) * Updating docs of this.getSlot Previous comment seemed off, suggesting an update that I think is clearer * Updated my update to docs * Updates per feedback Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * fix: #1490: Make pfe-icon set CSS properties instead of overriding local var (#1491) * test: Adjusting the visual regression test ratios and fixing test bugs (#1528) * test: Pushing the ratios higher * test: Updating tabs issues on snapshots, working through issues with overflow on the IE baselines; pfe-band bug? * test: Updating baselines * test: Revert pfe-band updates * test: Remove pfe-band dependency * test: Update baselines for pfe-tabs * Update elements/pfe-tabs/demo/demo.css * Remove interpolation and add IE11 fallback for surfaces * test: Pull out pfe-base updates into separate PR * test: Move broadcasted styles to demo.css in pfe-tabs instead of sourcing from base Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: Update package with clean tasks (#1531) * chore: Update package with clean tasks * chore: Move component clean to script * chore: Remove package-lock from the clean task * chore: Interpolate js variable in build script * chore: Add clean:all, remove preinstall clean task * chore: Update package to remove postci task * chore: Components already clean themselves up in the gulp task 🤦♀️ * Delete content inside the vrt-snapshots folder, not the folder itself * chore: Focus e2e cleaning on specific files * chore: Remove the clean task from clean:all because it deletes node_modules * Update README.md * Update README.md * Update README.md * Update README.md * feat: pfe-readtime (#1510) * cleaned up code and tied it all together * fix word-count calculation functionality * Updating readtime calculation to be based on the average readtime of supported countries * update demo page styles as well as add language code functionality * remove some css * demo page updates * Pair programming * WIP updates for multiple calls to functions from observers. * fix JS * fix for -forChangedHandler * update pfe-readtim_test * Update JS to not show pfe-readtime if the calculated readtime is <1 minute and update demo page to show this example in action. * Update elements/pfe-readtime/demo/pfe-readtime.story.js Co-authored-by: [ Cassondra ] <[email protected]> * Update elements/pfe-readtime/README.md Co-authored-by: [ Cassondra ] <[email protected]> * some code review feedback items * update vue and react test.html files * code review updates * update readme * add var for font size * WIP: AT updates * clean up test.html * fix: added setup element references to readtime element * fixes for lang fuctionality * cleanup of lang code functionality * WIP: fix hidding readtime if there is no value * Adding in getters & attributes * update changelogs * Update baselines * add test for templateString * update templateString test name * Update tests * Revert clipboard update * Update storybook * Fix template error Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: heyMP <[email protected]> * Update changelog in advance of release tag * chore: version bumps from release/v1.5.0 (#1534) * v1.5.0 * remove bundles after 1.5.0 tag * Update Netlify badge on readme * fix: pfe-readtime word count calculation (#1537) * cleaned up code and tied it all together * fix word-count calculation functionality * Updating readtime calculation to be based on the average readtime of supported countries * update demo page styles as well as add language code functionality * remove some css * demo page updates * Pair programming * WIP updates for multiple calls to functions from observers. * fix JS * fix for -forChangedHandler * update pfe-readtim_test * Update JS to not show pfe-readtime if the calculated readtime is <1 minute and update demo page to show this example in action. * Update elements/pfe-readtime/demo/pfe-readtime.story.js Co-authored-by: [ Cassondra ] <[email protected]> * Update elements/pfe-readtime/README.md Co-authored-by: [ Cassondra ] <[email protected]> * some code review feedback items * update vue and react test.html files * code review updates * update readme * add var for font size * WIP: AT updates * clean up test.html * fix: added setup element references to readtime element * fixes for lang fuctionality * cleanup of lang code functionality * WIP: fix hidding readtime if there is no value * Adding in getters & attributes * update changelogs * Update baselines * add test for templateString * update templateString test name * Update tests * Revert clipboard update * Update storybook * Fix template error * Update readme * remove 1 test * replace wordcunt logic with a more accurate regex * fix js and minor updates to demos * Update elements/pfe-readtime/src/pfe-readtime.js Co-authored-by: [ Cassondra ] <[email protected]> * Update elements/pfe-readtime/src/pfe-readtime.js Co-authored-by: [ Cassondra ] <[email protected]> * branch feedback and updates to demo page Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: heyMP <[email protected]> * Update CHANGELOG-1.x.md * Create CHANGELOG-1.x.md * chore: version bumps from release v1.5.1 (#1539) * v1.5.1 * remove bundles after 1.5.1 tag * docs: moving documentation to 11ty (#1421) * docs: moving docs to 11ty * updating to v1.3.3 of PatternFly Elements * updating documentation footer link * Update README.md * fork: 11ty updates; scripting assist (#1508) * Work on creating a "source of truth" for the docs * Add docs folder * Update build to pull in assets from components * Remove component assets from git log * Update readme instructions; add script for installing 11ty * Update scripts * Minor CSS tweak to push footer to bottom no matter how much content exists Co-authored-by: castastrophe <[email protected]> * Alias deploy-docs script to build-docs * Ignore node_modules on the docs directory * Add storybook assets to the publish directory; update spandx localhost to use docs directory; add brand assets to docs build * Resolve assets missing from site during build * Update reference to brand assets * Update package to resolve warnings in console * Update all demo pages to source requirejs from a cdn instead of as a dependency of the project * Update node modules references to use locally built components * Updating referencing to CDNs * Remove travis config * Remove storybook copy as it's built to the docs directory now Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: castastrophe <[email protected]> * chore: Update builds to run in parallel; fix watch error (#1535) * chore: Update builds to run in parallel; fix watch error * chore: Add async support for watch tasks Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: Fix watch task failure (#1543) * docs: migrate 11ty config to the root of the project (#1542) * chore: Update builds to run in parallel; fix watch error * chore: Add async support for watch tasks * docs: Resolve storybook error; migrate 11ty templates * docs: Abstracting header and footer * docs: Working through rendering issue * docs: Remove build script * docs: Update mkdir logic * docs: Clean up templates * docs: Update templates for imports * docs: Updating the config * docs: Remove doc-listing-inject for now * docs: Update doc listing logic * docs: Add a way to render the TODOS are JSON * docs: Apply design suggestions from Dan * docs: Updating READMEs * docs: Updating CDN references * docs: Update package and remove spandx config * docs: Adjusting the watch script * docs: Update build script * docs: Adjust how packages are brought in so they are loaded in the head * docs: Temporarily remove packages * docs: Run build before storybook and docs * docs: Update build flow * docs: Change mkdir logic * docs: Update script for build * docs: Maintain link to demo pages in footer of production * docs: Fix parallelization in watch task * docs: Update README Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(deps): [security] bump y18n from 3.2.1 to 3.2.2 (#1544) * chore(deps): [security] bump y18n from 3.2.1 to 3.2.2 Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2. **This update includes a security fix.** - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot-preview[bot] <[email protected]> * y18n update validates object.entries Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * Add done to watch to prevent async error * chore(deps-dev): bump leasot from 11.6.0 to 12.0.0 (#1524) Bumps [leasot](https://github.com/pgilad/leasot) from 11.6.0 to 12.0.0. - [Release notes](https://github.com/pgilad/leasot/releases) - [Commits](https://github.com/pgilad/leasot/compare/v11.6.0...v12.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump @babel/core from 7.13.14 to 7.13.15 (#1526) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.13.14 to 7.13.15. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.13.15/packages/babel-core) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * fix: [pfe-primary-detail] usable in IE11 (#1351) (#1352) * 1351: Fixed primary-detail so it's usable in IE11 Avoided replacing nav item markup, which was causing bugs and duplicate content in IE11 Added CSS for IE * Removing duplicate code * Update 11ty documentation after latest merge from master * Remove console log * Update changelog and baseline images * Newline in CHANGELOG fix Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs: Move polyfill and todo reports to docs folder (#1548) * docs: Move polyfill and todo reports to docs * docs: Update package and commit json assets Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: Add JSdoc for pfelement (#89) (#1520) * feat: Add JSdoc for pfelement * feat: Update changelog * feat: Preserve example page * feat: Remove compiled assets from commit * feat: Remove commented out config and link to documentation * feat: Update package; remove jsdoc for gulp-jsdoc3 * Update gulpfile.js * Update gulpfile.factory.js * Update gulpfile.factory.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs: fix footer bug on pages with left-side navigation (#1546) * chore: Update builds to run in parallel; fix watch error * chore: Add async support for watch tasks * docs: Resolve storybook error; migrate 11ty templates * docs: Abstracting header and footer * docs: Working through rendering issue * docs: Remove build script * docs: Update mkdir logic * docs: Clean up templates * docs: Update templates for imports * docs: Updating the config * docs: Remove doc-listing-inject for now * docs: Update doc listing logic * docs: Add a way to render the TODOS are JSON * docs: Apply design suggestions from Dan * docs: Updating READMEs * docs: Updating CDN references * docs: Update package and remove spandx config * docs: Adjusting the watch script * docs: Update build script * docs: Adjust how packages are brought in so they are loaded in the head * docs: Temporarily remove packages * docs: Run build before storybook and docs * docs: Update build flow * docs: Change mkdir logic * docs: Update script for build * docs: Maintain link to demo pages in footer of production * docs: Fix parallelization in watch task * docs: Update README * docs: Update basic to move footer into main * docs: Update footer styles Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(deps-dev): bump caniuse-db from 1.0.30001208 to 1.0.30001216 (#1557) Bumps [caniuse-db](https://github.com/Fyrd/caniuse) from 1.0.30001208 to 1.0.30001216. - [Release notes](https://github.com/Fyrd/caniuse/releases) - [Commits](https://github.com/Fyrd/caniuse/commits) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * fix: Updating pfelement to cascade `on` attribute; add back persist test (#1554) * fix: Updating pfelement to cascade on attribute * fix: Bring back comments removed and tidy up parent selector * fix: Update which function is run for on attribute rendering * fix: Update changelog * fix: Add check for parentNode * fix: Switch back to parentNode * fix: Fixing resetContext logic * fix: Switch content set to use resetContext and remove console outputs * fix: Remove duplicate isPFElement * fix: Remove isPFElement Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: castastrophe <[email protected]> * Update CHANGELOG-1.x.md * chore: Release/v1.6.0 (#1561) * v1.6.0 * remove bundles after 1.6.0 tag Co-authored-by: castastrophe <[email protected]> * chore: (deps-dev): bump gulp-replace from 1.0.0 to 1.1.1 (#1558) * chore(deps-dev): bump gulp-replace from 1.0.0 to 1.1.1 Bumps [gulp-replace](https://github.com/lazd/gulp-replace) from 1.0.0 to 1.1.1. - [Release notes](https://github.com/lazd/gulp-replace/releases) - [Commits](https://github.com/lazd/gulp-replace/commits) Signed-off-by: dependabot-preview[bot] <[email protected]> * compile latest Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: castastrophe <[email protected]> * chore: (deps-dev) bump postcss from 8.2.10 to 8.2.12 (#1556) * chore(deps-dev): bump postcss from 8.2.10 to 8.2.12 Bumps [postcss](https://github.com/postcss/postcss) from 8.2.10 to 8.2.12. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.2.10...8.2.12) Signed-off-by: dependabot-preview[bot] <[email protected]> * Remove prettier on json * Add -x to prevent leasot from throwing bad exit error https://www.npmjs.com/package/leasot Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: castastrophe <[email protected]> * chore(deps-dev): bump @storybook/addon-knobs from 6.2.7 to 6.2.9 (#1559) Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.2.7 to 6.2.9. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/knobs) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: Fix the JSDoc missing assets on 11ty (#1569) * remove always-false condition from _convertSelectorsToArray (#1568) Co-authored-by: [ Cassondra ] <[email protected]> * fix: pfe-accordion add bottom padding to disclosure panel (#1397) (#1443) Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: Kyle Buchanan <[email protected]> Co-authored-by: Kendall Totten <[email protected]> * fix: Updating demo custom styles (#1589) * fix: Updating demo custom styles * Update elements/pfe-accordion/demo/index.html * fix: Update pfelement logging so arrays and objects get printed (#1573) (#1574) * fix: Updating PFElement.log so it logs arrays and objects Instead of converting them to strings Code actually written by @mwcz, despite being committed by @wesruv Issue #1573 * Update CHANGELOG-1.x.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore: Update generator with knobs import; add events (#1527) * chore: Update generator * chore: Update logic for events in storybook template * chore: Revert test listing, update line breaking in generator * Update test/index.html * chore: Update package lock Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Upgrade to GitHub-native Dependabot (#1566) * Upgrade to GitHub-native Dependabot * Update dependabot.yml Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(deps-dev): bump @storybook/addon-viewport from 6.2.7 to 6.2.9 (#1577) Bumps [@storybook/addon-viewport](https://github.com/storybookjs/storybook/tree/HEAD/addons/viewport) from 6.2.7 to 6.2.9. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/viewport) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * feat: add Web Test Runner framework and tooling (#1538) * Web Test Runner POC * Removes old test files and adds new test * Updates generator for new tests * Adds new test script and generator for new tests * Adds new tooling to run tests * Updates docs and wtr scripts. * Updates readme to show test generator * Fixes test script for pfe-select element * Updates wtr glob so it doesn't select node_modules tests * Adds caching for ms-playright * Resolves merge conflicts * Updates old react and vue tests to use a CDN instead of local libraries * chore: Update builds to run in parallel; fix watch error (#1535) * chore: Update builds to run in parallel; fix watch error * chore: Add async support for watch tasks Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs: migrate 11ty config to the root of the project (#1542) * chore: Update builds to run in parallel; fix watch error * chore: Add async support for watch tasks * docs: Resolve storybook error; migrate 11ty templates * docs: Abstracting header and footer * docs: Working through rendering issue * docs: Remove build script * docs: Update mkdir logic * docs: Clean up templates * docs: Update templates for imports * docs: Updating the config * docs: Remove doc-listing-inject for now * docs: Update doc listing logic * docs: Add a way to render the TODOS are JSON * docs: Apply design suggestions from Dan * docs: Updating READMEs * docs: Updating CDN references * docs: Update package and remove spandx config * docs: Adjusting the watch script * docs: Update build script * docs: Adjust how packages are brought in so they are loaded in the head * docs: Temporarily remove packages * docs: Run build before storybook and docs * docs: Update build flow * docs: Change mkdir logic * docs: Update script for build * docs: Maintain link to demo pages in footer of production * docs: Fix parallelization in watch task * docs: Update README Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixes typo * Updates per code review * Updates the test echo now that we support single element watching * Updates pfe-select test command to match the generator * Adds changelong * Changelog update Co-authored-by: Zack Hawkins <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump @storybook/addon-actions from 6.2.7 to 6.2.9 (#1575) Bumps [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/addons/actions) from 6.2.7 to 6.2.9. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/actions) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * Bump yo version (#1599) * chore: Add a tool to open an issue if the build on master breaks (#1602) * Add a tool to open an issue if the build on master breaks * Add more details to issue message * Include new test framework * Validate that the script runs by forcing pfe-accordion test to fail * Let the build run on pushes to master * Output context * Debugging * Prevent debug from failing * Convert to JSON * Add checks for build and skip ci * Fix ref name * Update validate logic * Add task to assign new issues to the prioritization board * Update test duplication of jobs * Support validate run if previous tasks are skipped * Fix interpolation * Remove failing test and fix commented out code for testing * Update tests * chore: (deps-dev): bump husky from 5.2.0 to 6.0.0 (#1579) * chore(deps-dev): bump husky from 5.2.0 to 6.0.0 Bumps [husky](https://github.com/typicode/husky) from 5.2.0 to 6.0.0. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](https://github.com/typicode/husky/compare/v5.2.0...v6.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * Update changelog; validate husky update * Update CHANGELOG-1.x.md * Remove support for alex bot Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore: (deps-dev): bump chalk from 4.1.0 to 4.1.1 (#1591) * chore(deps-dev): bump chalk from 4.1.0 to 4.1.1 Bumps [chalk](https://github.com/chalk/chalk) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/chalk/releases) - [Commits](https://github.com/chalk/chalk/compare/v4.1.0...v4.1.1) Signed-off-by: dependabot[bot] <[email protected]> * Update package-lock Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump postcss from 8.2.12 to 8.2.14 (#1590) Bumps [postcss](https://github.com/postcss/postcss) from 8.2.12 to 8.2.14. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.2.12...8.2.14) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: Accordion expand on load (#859) (#1583) * feat: Setting up support for selected-index; history; and fix a few small styling bugs * feat: Adding variable hooks to pfe-layouts * feat: History in URL is working * feat: Adding multi-select to the expanded-index attribute * feat: Update documentation * feat: Updating baselines * feat: Update accordion header styles for disclosure to fix IE11 preview * feat: Update baseline for IE11 * feat: Updating disclosure regression * feat: Update accordion tests * feat: Uncomment out framework tests * feat: Update changelog; demo page * feat: Adding in spacing * feat: Update package-lock * feat: Add full-width demo example to pfe-band * feat: Update storybook * feat: Resolve failing tests on accordion; update storybook * feat: Update console log tests * feat: Resolve rounding error in pfe-card tests * feat: Resolving test errors * feat: Resolve pfelement console errors and content set inconsitencies * Apply suggestions from code review * feat: Update package-lock * Update CHANGELOG-1.x.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update changelog for 1.7.0 release * chore: version bumps from release/v1.7.0 (#1612) * v1.7.0 * remove bundles after 1.7.0 tag * chore(deps-dev): bump rollup-plugin-terser from 4.0.4 to 5.3.1 (#1596) Bumps [rollup-plugin-terser](https://github.com/TrySound/rollup-plugin-terser) from 4.0.4 to 5.3.1. - [Release notes](https://github.com/TrySound/rollup-plugin-terser/releases) - [Commits](https://github.com/TrySound/rollup-plugin-terser/compare/v4.0.4...v5.3.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump markdown-it from 12.0.5 to 12.0.6 (#1595) Bumps [markdown-it](https://github.com/markdown-it/markdown-it) from 12.0.5 to 12.0.6. - [Release notes](https://github.com/markdown-it/markdown-it/releases) - [Changelog](https://github.com/markdown-it/markdown-it/blob/master/CHANGELOG.md) - [Commits](https://github.com/markdown-it/markdown-it/compare/12.0.5...12.0.6) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump @wdio/mocha-framework from 7.3.1 to 7.5.3 (#1592) Bumps [@wdio/mocha-framework](https://github.com/webdriverio/webdriverio) from 7.3.1 to 7.5.3. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/compare/v7.3.1...v7.5.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump caniuse-db from 1.0.30001216 to 1.0.30001223 (#1597) Bumps [caniuse-db](https://github.com/Fyrd/caniuse) from 1.0.30001216 to 1.0.30001223. - [Release notes](https://github.com/Fyrd/caniuse/releases) - [Commits](https://github.com/Fyrd/caniuse/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump node-sass from 5.0.0 to 6.0.0 (#1608) Bumps [node-sass](https://github.com/sass/node-sass) from 5.0.0 to 6.0.0. - [Release notes](https://github.com/sass/node-sass/releases) - [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/node-sass/compare/v5.0.0...v6.0.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * Add the opened pull request task to the cc-format task (#1620) * fix: IE11 regression; background should be set to white to prevent context errors (#1619) * fix: IE11 regression; background should be set to white to prevent context errors * fix: Update changelog * fix: Update baselines * fix: Remove IE11 accordion baseline * ci: pull request and review types for confirming commit syntax * feat: [pfe-icon] add default icon set configuration (#1550) * Allows pfe-icon to accept a global config for icon sets. * Adds tests for new pfe-icon config options. * Updates changelog * Updates PR per code review * Adds additional todos * Updates pfe-icon config to support resolveIconName function * Removes example code for pfe-icon Co-authored-by: Zack Hawkins <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore: pfe-dropdown package.json fix (#1553) * pfe-dropdown package.json fix * Apply suggestions from code review per @castastrophe's suggestion, update the `module` path as well Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: Michael Clayton <[email protected]> Co-authored-by: [ Cassondra ] <[email protected]> * chore: Update tests and build scripts (#1607) * chore: Update tests and build scripts * chore: Fix modal inconsistency * chore: Remove unnecessary package * chore: Update baselines * chore: Update tests to prevent false failures * chore: Update pfe-toast baselines * chore: Add support for * in the validateElements tool Co-authored-by: castastrophe <[email protected]> * chore: (CI) split out build failure issue from test failure issue * chore: Update location of the knobs panel (#1624) * chore: Update location of the knobs panel * Update .storybook/config.js * Update .storybook/config.js * feat: Update fetch mixin to support region input (#1328) (#1626) * fix: Update fetch mixin to support region input * fix: Update changelog and documentation * fix: [pfe-icon] icon color vs. background-color discrepancy (#1541) (#1545) * fix: Update flood color on background circle to use broadcast context instead * fix: Update pfe-icon styles to support background color and color * fix: Add additional documentation' * fix: Update internal mixin * fix: Clean up block references * fix: Update changelog * fix: newline 🤦♀️ * fix: Create deprecated section * fix: Resolve duplication and missing hook * fix: Adjusting icon values * Update elements/pfe-icon/README.md Co-authored-by: Kendall Totten <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kendall Totten <[email protected]> * chore(deps-dev): bump postcss from 8.2.14 to 8.2.15 (#1630) Bumps [postcss](https://github.com/postcss/postcss) from 8.2.14 to 8.2.15. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.2.14...8.2.15) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump glob from 7.1.6 to 7.1.7 (#1627) Bumps [glob](https://github.com/isaacs/node-glob) from 7.1.6 to 7.1.7. - [Release notes](https://github.com/isaacs/node-glob/releases) - [Changelog](https://github.com/isaacs/node-glob/blob/master/changelog.md) - [Commits](https://github.com/isaacs/node-glob/compare/v7.1.6...v7.1.7) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore: Remove old travis files (#1634) * fix: Add in missing polyfills for pfelement (#1625) * fix: Add in missing polyfills for pfelement * fix: Update changelog * fix: Remove polyfill reference * Update CHANGELOG-1.x.md * Update changelog date * chore: version bumps from release/v1.8.0 (#1635) * v1.8.0 * remove bundles after 1.8.0 tag * chore(deps-dev): bump caniuse-db from 1.0.30001223 to 1.0.30001226 (#1629) Bumps [caniuse-db](https://github.com/Fyrd/caniuse) from 1.0.30001223 to 1.0.30001226. - [Release notes](https://github.com/Fyrd/caniuse/releases) - [Commits](https://github.com/Fyrd/caniuse/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump playwright from 1.10.0 to 1.11.0 (#1628) Bumps [playwright](https://github.com/Microsoft/playwright) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/Microsoft/playwright/releases) - [Commits](https://github.com/Microsoft/playwright/compare/v1.10.0...v1.11.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * feat: [pfe-styles] ordered list styles (#1571) * feat: verbose ordered-list-primary extend * feat: switched away from local sass variables. added grid to demo. * fix: fixed demo styles overriding padding on * feat: center align ol.pfe-styles demo * feat: added ul pfe-list styles * Revert "feat: added ul pfe-list styles" This reverts commit 633742328c1124862bc01a7987fcca9d5f77ace9. * feat: improved margin on ol parent * feat: added ie11 fallback for display * fix: moved variables to pfe-local * fix: remove root CSS variables. Fixed pfe-local statements. Added variable stack to BackgroundColor * fix: added fallbacks to margin * feat: added prefix pfe-ol-list--primary * feat: added prefix pfe-list-ol--primary * fix: added better list selector to demo * chore: update README * feat: added design hooks for pfe-grid. using hooks in pfe-list * feat: updated README. changed gap to spacer api * Typo update * feat: moved ol.pfe-list--primary to typography file * feat: added design hook for removing an items first child margin * Update elements/pfe-sass/mixins/_components.scss Co-authored-by: Kendall Totten <[email protected]> * fix: added more descriptive name to li numbers font size * chore: update changelog * Update CHANGELOG-1.x.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: Kendall Totten <[email protected]> * feat: persist _debugLog in localStorage (#1570) * feat: pfe-progress-steps [new component] (#1436) (#1613) * fix: merged master fix and issue-1405-product-trials-epic--broken-master * feat: added better logic for switching grid gaps for button-group * feat: updated demo * feat: pfe-progress-steps disable link on current and error state. * feat: pfe-progress-steps fixed thin white line around svgs * chore: pfe-progress-steps cleanup * feat: updated demo to use remote libs * fix: pfe-popover fixed darkmode button color * feat: pfe-absolute-position switch from attr change callback to prop observers * fix: pfe-alert added correct icon gap, moved to css grid * chore: update to 1.6.0 * chore: commit dist files for short term * chore: remove dist files * chore: removing unrelated components * chore: removing dist directories * chore: remove console.log * feat: made vertical min-height dynamic * chore: version bump * First pass at updating styles to use pfe functions * Remove debugging * Update polyfills * Add documentation folder * Remove jump links content from progress stepper docs * Add documentation for the variable hooks * Update documentation; add values array * First pass at storybook view * Abstract item template * Update story * Update tests for progress steps * Update progress steps * Add todo notes * Remove progress steps html now that it's using the new testing framework * [pfe-progress-steps] CSS Variable Notes NO MERGE (#1623) * feat: added inline comments * Update elements/pfe-progress-steps/src/pfe-progress-steps-item.scss * Update elements/pfe-progress-steps/src/pfe-progress-steps-item.scss * Update elements/pfe-progress-steps/src/pfe-progress-steps-item.scss * Apply suggestions from code review * Allow text to inherit font color * Adding a few setters Co-authored-by: [ Cassondra ] <[email protected]> * Reworking the styles to simplify the markup * Fixing a few hangnails * Update links to use inherit * Update logic to use more precise math for determining alignment * Revert storybook update * Minor updates * update changelog * Updating typo * Remove html test from old testing suite * Update styles on demo page * feat: updated css vars for RH theme in demo * feat: updated preview image for docs * fix: fixed the description of the progress steps * Update feedback--info colors to ui-accent Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore: Update baselines before tag release 1.9.0 (#1645) * Update index.md * Update CHANGELOG-1.x.md * chore: version bumps from release/v1.9.0 (#1646) * v1.9.0 * remove bundles after 1.9.0 tag * Update CHANGELOG-1.x.md * fix: Content set, Safari 14.1.1. / WebKitGTK 2.32.0 (#1650) * fix: Update content set to workaround Safari 14.1.1, WebKitGTK 2.32.0 bug * fix: Update commented out line * fix: Correct commented out break * fix: Update changelog * fix: Revert unrelated linting updates * fix: Set resize observer on this * fix: Switch to onresize event; update container query * fix: Add debounce * fix: Remove commented out resize * fix: Rework building content * fix: Revert breakpoint change * fix: Build wrapper no longer used * fix: Update tests to use promises * fix: IE11 bug fix * fix: Updated baselines for IE11 * fix: Update readme * fix: Add IE11 note to docs * Update changelog before tag * chore: version bumps from release/v1.9.1 (#1651) * v1.9.1 * remove bundles after 1.9.1 tag * chore(deps-dev): bump prettier from 1.19.1 to 2.3.0 (#1640) Bumps [prettier](https://github.com/prettier/prettier) from 1.19.1 to 2.3.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/1.19.1...2.3.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @web/test-runner from 0.12.20 to 0.13.5 (#1647) Bumps [@web/test-runner](https://github.com/modernweb-dev/web/tree/HEAD/packages/test-runner) from 0.12.20 to 0.13.5. - [Release notes](https://github.com/modernweb-dev/web/releases) - [Changelog](https://github.com/modernweb-dev/web/blob/master/packages/test-runner/CHANGELOG.md) - [Commits](https://github.com/modernweb-dev/web/commits/@web/[email protected]/packages/test-runner) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump @wdio/spec-reporter from 7.3.1 to 7.6.1 (#1648) Bumps [@wdio/spec-reporter](https://github.com/webdriverio/webdriverio) from 7.3.1 to 7.6.1. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/compare/v7.3.1...v7.6.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * fix: Fix content set ID copy to shadow dom (#1653) * fix: Fix content set ID copy to shadow dom * chore: spell check fix Co-authored-by: Michael Potter <[email protected]> * chore: Update changelog for 1.9.2 release * chore: version bumps from release/v1.9.2 (#1660) * v1.9.2 * remove bundles after 1.9.2 tag * docs: Update testing docs with new examples (#1643) * US293986 Updates docs for testing * US293986 Update docs based on feedback Co-authored-by: Zack Hawkins <[email protected]> Co-authored-by: Kyle Buchanan <[email protected]> * chore: Add webdriver badge to README * chore: dependabot wdio update throwing unexpected e2e error (#1668) * chore: Dependabot wdio update throwing unexpected e2e error * chore: Update pfe-modal with missing polyfil * chore: Pull out unrelated jump links update * chore: Update collapse baseline for IE and clipboard acceptance ratio * chore: Correct browser logic for skipping IE baselines in pfe-icon and pfe-progress-steps * chore: Update baseliens for icon and dropdown * chore: Update configuration for dependabot * chore: Dependabot configuration update * chore: bump caniuse-db from 1.0.30001226 to 1.0.30001232 (#1661) * chore(deps-dev): bump caniuse-db from 1.0.30001226 to 1.0.30001232 Bumps [caniuse-db](https://github.com/Fyrd/caniuse) from 1.0.30001226 to 1.0.30001232. - [Release notes](https://github.com/Fyrd/caniuse/releases) - [Commits](https://github.com/Fyrd/caniuse/commits) Signed-off-by: dependabot[bot] <[email protected]> * Update package-lock Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump gulp-replace from 1.1.1 to 1.1.3 (#1656) Bumps [gulp-replace](https://github.com/lazd/gulp-replace) from 1.1.1 to 1.1.3. - [Release notes](https://github.com/lazd/gulp-replace/releases) - [Commits](https://github.com/lazd/gulp-replace/compare/v1.1.1...v1.1.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @storybook/storybook-deployer from 2.8.7 to 2.8.8 (#1655) Bumps [@storybook/storybook-deployer](https://github.com/storybooks/storybook-deployer) from 2.8.7 to 2.8.8. - [Release notes](https://github.com/storybooks/storybook-deployer/releases) - [Changelog](https://github.com/storybookjs/storybook-deployer/blob/master/CHANGELOG.md) - [Commits](https://github.com/storybooks/storybook-deployer/compare/v2.8.7...v2.8.8) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(deps-dev): bump chromedriver from 89.0.0 to 90.0.1 (#1639) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 89.0.0 to 90.0.1. - [Release notes](https://github.com/giggio/node-chromedriver/releases) - [Commits](https://github.com/giggio/node-chromedriver/compare/89.0.0...90.0.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: Adjust acceptance ratios for E2E * chore(deps-dev): bump sinon from 9.2.4 to 11.1.1 (#1659) Bumps [sinon](https://github.com/sinonjs/sinon) from 9.2.4 to 11.1.1. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md) - [Commits](https://github.com/sinonjs/sinon/compare/v9.2.4...v11.1.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> * chore(deps-dev): bump dotenv from 8.2.0 to 10.0.0 (#1654) Bumps [dotenv](https://github.com/motdotla/dotenv) from 8.2.0 to 10.0.0. - [Release notes](https://github.com/motdotla/dotenv/releases) - [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md) - [Commits](https://github.com/motdotla/dotenv/compare/v8.2.0...v10.0.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: set margin-top for ctas in footer on mobile (#1667) * US296521 fix: set margin-top for ctas in footer after the second one. * US296521 - reset margin-top to 0 for CTAs on desktop * fix: fixed z-index issue on demo page. * chore: update changelog Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: heyMP <[email protected]> * chore: bump caniuse-db from 1.0.30001232 to 1.0.30001235 (#1671) * Update package.json (#1674) bugfix wrong filename in package jason Co-authored-by: Jochen Kühner <[email protected]> * Updating tests for new testing suite and fixing some merge conflicts Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kendall Totten <[email protected]> Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: castastrophe <[email protected]> Co-authored-by: alazzara <[email protected]> Co-authored-by: heyMP <[email protected]> Co-authored-by: Kyle Buchanan <[email protected]> Co-authored-by: Michael Clayton <[email protected]> Co-authored-by: bdone <[email protected]> Co-authored-by: Zack Hawkins <[email protected]> Co-authored-by: Zack Hawkins <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Homa <[email protected]> Co-authored-by: Chris Doherty <[email protected]> Co-authored-by: Jochen Kühner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Margin-top is not applied to the CTAs in pfe-navigation footer after the fourth. Set the Light DOM styles for mobile so that the fifth (and subsequent) CTAs have the correct margins.
Preview
Link(s) to demo page(s) where this element can be viewed:
What has changed and why
pfe-navigation--lightdom.scssat breakpoint-sm, changed the selector containing the margin-top property fromnth-child(3), nth-child(4)tonth-child(n+3)Testing instructions
900pxBrowser requirements
Your component should work in all of the following environments:
Ready-for-merge Checklist
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the [email protected] mailing list!