-
Notifications
You must be signed in to change notification settings - Fork 106
feat: primary details mobile optimization #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: primary details mobile optimization #1582
Conversation
continued working on keyboard feature, added light dom scss file.
Got arrow key features working per tab instance
Cleaned up comments and stale code, added explicit setting of tabindex 0 to next toggle since the buttons were changed to heading tags to address IE11 issues
Add focus style indicator for active and focus state, increase clickable area of links
Updates based on feedback and add logic to adjust the tabindex attrs for active toggles and tabpanels on page load
…gure out how to address tabindex issue with footer region of tabs
Made progress on fixing tab order issue for tab footer section and active panels
continued troubleshooting tab order and visibility issue
continued trying method to address tab order issue with details footer
…VS Code ext and making the build fail
…atternfly-elements into CPFED-4017-based-off-master
…ooter slot to fix tab order issue, add js to add focus style class to fix web comp psuedo selector issue
…atternfly-elements into CPFED-4017-based-off-master
|
Ahh, coolio. Next time I'd push a different branch unless this is a show-stopping issue? |
Hey @wesruv unfortunately it is a show stopping issue. The issues I found make the component unusable on mobile with a screen reader. I am working on the fixes and will keep you posted. |
…row indicators to the mobile view of the toggles.
…ub.com:patternfly/patternfly-elements into CPFED-4084-primary-details-mobile-optimization
…hat pronunciations to use, addresses lighthouse issues as well
|
Hey @kylebuch8 Wes updated the tests and I tested with a screen reader again on desktop and mobile and we are golden there. Also below is the latest a11y lighthouse report. Latest Lighthouse report |
kelsS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ♿🎉
…ub.com:patternfly/patternfly-elements into CPFED-4084-primary-details-mobile-optimization
breakpoint-widthattribute with a default value of 800, if the width of the component goes below this number it goes to mobile layoutbreakpointattribute, displays what breakpoint the component is using "compact" or "desktop"Related issues
Preview
Link(s) to demo page(s) where this element can be viewed:
Testing instructions
Run the tests on the component
Test in older browsers
Browser requirements
Your component should work in all of the following environments:
Ready-for-merge Checklist
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the [email protected] mailing list!