Skip to content

Conversation

@wesruv
Copy link
Contributor

@wesruv wesruv commented May 4, 2021

  • Adds styles and behaviors necessary for a mobile optimized layout
    • Adds breakpoint-width attribute with a default value of 800, if the width of the component goes below this number it goes to mobile layout
    • Adds breakpoint attribute, displays what breakpoint the component is using "compact" or "desktop"
    • Added better focus styles
  • Moved to new testing framework
    • Added more thorough testing
    • Got rid of files for old testing framework
    • Fixed errors found while writing tests
  • Added docs
    • for new functionality
    • for a11y information
    • for new testing framework

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

Testing instructions

  • Check desktop layout
    1. Open window at 1000px+ wide window
    2. Make sure layout is two column
    3. Click on nav items, make sure the content on the right changes
    4. Use keyboard navigation, when on tabs the arrow keys are used to navigate the tabs, everything else uses tabs
  • Check mobile layout
    1. Open page at 500px or less wide window
    2. Make sure the first column (the nav side) is visible
    3. Click on nav item, it should slide over to the content side
    4. Click back or escape and it should go back to the nav side
  • Check going from one breakpoint to another
    1. Make sure if something is open at desktop, it remains open at mobile
    2. Make sure that something is always open at desktop, the right column should never be empty (have nothing selected at mobile then go to desktop)

Run the tests on the component

Test in older browsers

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

kelsS and others added 30 commits February 24, 2021 15:49
continued working on keyboard feature, added light dom scss file.
Got arrow key features working per tab instance
Cleaned up comments and stale code, added explicit setting of tabindex 0 to next toggle since the buttons were changed to heading tags to address IE11 issues
Add focus style indicator for active and focus state, increase clickable area of links
Updates based on feedback and add logic to adjust the tabindex attrs for active toggles and tabpanels on page load
…gure out how to address tabindex issue with footer region of tabs
Made progress on fixing tab order issue for tab footer section and active panels
continued troubleshooting tab order and visibility issue
continued trying method to address tab order issue with details footer
…atternfly-elements into CPFED-4017-based-off-master
…ooter slot to fix tab order issue, add js to add focus style class to fix web comp psuedo selector issue
…atternfly-elements into CPFED-4017-based-off-master
@kelsS kelsS added the work in progress POC / Not ready for review label Jul 23, 2021
@wesruv
Copy link
Contributor Author

wesruv commented Jul 23, 2021

Ahh, coolio. Next time I'd push a different branch unless this is a show-stopping issue?

@kelsS
Copy link
Contributor

kelsS commented Jul 27, 2021

Ahh, coolio. Next time I'd push a different branch unless this is a show-stopping issue?

Hey @wesruv unfortunately it is a show stopping issue. The issues I found make the component unusable on mobile with a screen reader. I am working on the fixes and will keep you posted.

@github-actions github-actions bot added the AT passed Automated testing has passed label Aug 5, 2021
…hat pronunciations to use, addresses lighthouse issues as well
@kelsS
Copy link
Contributor

kelsS commented Aug 5, 2021

Hey @kylebuch8 Wes updated the tests and I tested with a screen reader again on desktop and mobile and we are golden there. Also below is the latest a11y lighthouse report.

Latest Lighthouse report
pfe-primary-detail-a11y-audit-08-05-21.pdf

Copy link
Contributor

@kelsS kelsS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ♿🎉

@kylebuch8 kylebuch8 self-requested a review August 16, 2021 20:46
@kylebuch8 kylebuch8 enabled auto-merge (squash) August 16, 2021 20:48
@kylebuch8 kylebuch8 removed the work in progress POC / Not ready for review label Aug 16, 2021
@kylebuch8 kylebuch8 changed the title feat: CPFED-4084 primary details mobile optimization feat: primary details mobile optimization Aug 18, 2021
@kylebuch8 kylebuch8 merged commit 489c561 into master Aug 18, 2021
@kylebuch8 kylebuch8 deleted the CPFED-4084-primary-details-mobile-optimization branch August 18, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants