Skip to content

feat: Add nav-label functionality to pfe-jump-links #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
castastrophe wants to merge 3 commits into from
Closed

feat: Add nav-label functionality to pfe-jump-links #1549

castastrophe wants to merge 3 commits into from

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Apr 21, 2021 •
edited
Loading

DO NOT MERGE. THIS PR IS PURELY FOR CODE REVIEW AND WILL BE ROLLED AS v1.0.0-prerelease.59

Add nav-label functionality

  • Added support for a nav-label attribute to be used in autobuild pfe-jump-links-nav elements

Preview

Link(s) to demo page(s) where this element can be viewed:

Testing instructions

  • nav-label
    1. Add a nav-label attribute with string value to any of the headings in the pfe-jump-links-panel that pairs with a pfe-jump-links-nav containing an autobuild attribute. :)
    2. The rendered nav should use the nav-label rather than the heading text.

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Safari

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

@castastrophe castastrophe added feature New feature or request ready: branch testing Test the component from a user-perspective. Try to break it! ready: browser testing Test the component in the supported browser environments. ready: code review Ready for code review! labels Apr 21, 2021
heyMP
heyMP approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@heyMP heyMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@castastrophe castastrophe removed the ready: code review Ready for code review! label Apr 21, 2021
@heyMP
Copy link
Contributor

heyMP commented Apr 21, 2021

Branch testing passed 🎉

Screen Shot 2021-04-21 at 1 21 30 PM

@castastrophe castastrophe removed ready: branch testing Test the component from a user-perspective. Try to break it! ready: browser testing Test the component in the supported browser environments. labels Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heyMP heyMP heyMP approved these changes

Assignees

No one assigned

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@castastrophe @heyMP