Skip to content

fix: saturated visited link color #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
castastrophe merged 18 commits into from
Nov 25, 2020
Merged

fix: saturated visited link color #1127

castastrophe merged 18 commits into from
Nov 25, 2020

Conversation

@starryeyez024
Copy link
Member

@starryeyez024 starryeyez024 commented Oct 5, 2020 •
edited
Loading

Component name

  • all components

Related issue

Preview

https://deploy-preview-1127--happy-galileo-ea79c4.netlify.app/elements/pfe-card/demo/

What has changed and why

  • Update visited link color to something that would pass accessibility standards on saturated backgrounds

Testing instructions

  1. Go to pfe-card demo
  2. Click on a link in the complement or accent card so that its "visited"
  3. Notice the link color is no longer purple, but a light gray instead.

Ready-for-merge Checklist

Check off items as they are completed. Feel free to delete items if they are not applicable.

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Repository compiles and tests pass.
  • Changelog updated (not needed for documentation updates).

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

@starryeyez024 starryeyez024 added bug styles An issue or PR pertaining only to CSS/Sass labels Oct 5, 2020
castastrophe
castastrophe suggested changes Oct 8, 2020
View reviewed changes
castastrophe
castastrophe approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 just needs changelog

@castastrophe castastrophe added ready: browser testing Test the component in the supported browser environments. needs changelog Be sure to update the Changelog before merging. labels Oct 8, 2020
@castastrophe
Copy link
Contributor

castastrophe commented Oct 8, 2020

Does this need any doc or test updates?

@castastrophe castastrophe changed the title Fix saturated visited link color fix: saturated visited link color Oct 8, 2020
@starryeyez024 starryeyez024 removed the needs changelog Be sure to update the Changelog before merging. label Oct 15, 2020
@starryeyez024
Copy link
Member Author

starryeyez024 commented Oct 20, 2020

browser testing results: https://docs.google.com/spreadsheets/d/1ET3MVUXzgR36CGkfU3wd4SCbj8Mc0eGUixQ5kxOmpsg/edit#gid=1660273076

@starryeyez024 starryeyez024 added ready to merge on hold wait to merge and removed ready: browser testing Test the component in the supported browser environments. styles An issue or PR pertaining only to CSS/Sass ready to merge labels Oct 20, 2020
@castastrophe castastrophe added this to the 1.0 release milestone Nov 17, 2020
@castastrophe castastrophe linked an issue Nov 17, 2020 that may be closed by this pull request
Saturated visited link color incorrect #1126
Closed
@castastrophe castastrophe added run e2e Trigger automated visual regression tests styles An issue or PR pertaining only to CSS/Sass and removed on hold wait to merge labels Nov 18, 2020
@castastrophe
Copy link
Contributor

castastrophe commented Nov 18, 2020

Does this need any doc or test updates?

Bump ^ @starryeyez024

kylebuch8
kylebuch8 approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Livery Going Through Machine (it was dirty)

castastrophe
castastrophe approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Pulled down and reviewed; updated baselines.

@github-actions github-actions bot added the demo Updating demo pages label Nov 24, 2020
@castastrophe castastrophe added ready to merge and removed run e2e Trigger automated visual regression tests labels Nov 24, 2020
@castastrophe castastrophe added the priority: high Severity level: 1 label Nov 25, 2020
@castastrophe castastrophe merged commit 40e0b09 into master Nov 25, 2020
@castastrophe castastrophe deleted the issue-1126 branch November 25, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylebuch8 kylebuch8 kylebuch8 approved these changes

+1 more reviewer

@castastrophe castastrophe castastrophe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

demo Updating demo pages priority: high Severity level: 1 ready to merge styles An issue or PR pertaining only to CSS/Sass

Projects

None yet

Milestone

1.0 release

Development

Successfully merging this pull request may close these issues.

Saturated visited link color incorrect

4 participants

@starryeyez024 @castastrophe @kylebuch8