Skip to content

[feat] pfelement | Update composed default to true in the emitEvent method #1581

@wesruv

Description

@wesruv

Description of the issue

Working with some analytics folks they mentioned they couldn't get the show/hide events from the tabs on redhat.com's contact page. The tabs are inside of a pfe-content-set and it looks like the events from the child components don't make it outside of pfe-content-set.

Impacted component(s)

  • pfe-content-set

Steps to reproduce

  1. Go to https://www.redhat.com/en/contact
  2. In the console, execute this code to show that the document isn't picking up the event: document.addEventListener('pfe-tabs:shown-tab', function(event) {console.log('lightDomListener', event)});
  3. Then execute this code to show that the shadowRoot does pick up the event: document.querySelector('pfe-content-set').shadowRoot.addEventListener('pfe-tabs:shown-tab', function(event) {console.log('shadowDomListener', event)});
  4. Click on tabs (e.g. Sales, Customer Service, Product & learning support, etc)

Expected behavior

I'm thinking pfe-content-set could boost the child events, and it might be nice if it pushed out a generic event (so a site dev wouldn't have to know which state the content set was in).

Metadata

Metadata

Assignees

No one assigned

    Labels

    functionalityFunctionality, typically pertaining to the JavaScript.integrationIntegration with JS/CSS libraries or frameworkspriority: lowSeverity level: 3

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions