Skip to content

[fix] pfe-navigation 1.x | line-height bug #1454

@LyndseyR

Description

@LyndseyR

Description of the issue

  • class="pfe-navigation__main--menu-label" has a different line-height then the words in the class=pfe-navigation__utility. This causes the mobile menu icon to sit lower when comparing it to the globe, search, user and 3x3-grid icons.
    • Word Menu has computed line-height: 13.2px
    • Word English has computed line-height: 18px

Impacted component(s)

  • pfe-navigation

Steps to reproduce

  1. Go to 'https://www.redhat.com/en'
  2. View the homepage at a screensize at 700px so you see the mobile menu icon
  3. Inspect the word Menu
  4. See the computed line-height being applied on pfe-navigation__main--menu-label
  5. Inspect the word English
  6. See the computed line-height being applied on pfe-navigation-item [slot=trigger]
  7. Visually see how the mobile icon is sitting lower than the other 4 icons.

Expected behavior

pfe-navigation__main--menu-label line height should match the line height of pfe-navigation-item [slot=trigger]. When it has the same line-height the mobile menu icon will sit at the same line as the globe, search, user and 3x3-grid icons.

Screenshots of showing bug

Screenshot-mobile-current-bug

Screenshot-tablet-current-bug

Screenshots with line height changed inline

Screenshot-mobile-line-height-fix
Screenshot-tablet-line-height-fix

Metadata

Metadata

Assignees

No one assigned

    Labels

    design systemUpdates or issues to align components to the Red Hat Design System.fixpriority: lowSeverity level: 3size: smSizing label; indicates a quick, relatively easy taskstylesAn issue or PR pertaining only to CSS/Sass

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions