Skip to content

release script no longer performs a build #1061

@kylebuch8

Description

@kylebuch8

Description of the issue

With the recent changes to the postinstall script, the release script no longer performs a build.

I think we'll need to add a npmBuild method that performs the build after the npmInstall method is executed.
https://github.com/patternfly/patternfly-elements/blob/master/scripts/release.sh#L134

The way I could tell that the build wasn't happening was because I was getting an error in the commitIgnoredFiles method letting me know that there were no files that matched the pattern elements/*/dist/.

This issues doesn't prevent us from releasing, but it could be a problem if someone does a release with stale component builds.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions