Skip to content

Fixed missing dtype for Newton/Chord #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2025
Merged

Conversation

patrick-kidger
Copy link
Owner

No description provided.

Comment on lines 134 to 136
def conj(self, state, options):
assert False

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This change is just an unrelated drive-by from an update over in Lineax, needed for pre-commits to pass.)

@johannahaffner johannahaffner changed the base branch from main to tidy-dev August 13, 2025 22:30
@johannahaffner
Copy link
Collaborator

This is now rebased on tidy-dev.

Changes:

  • We both added an identical .conj method to the custom linear solver in the benchmarks script, so I removed one of the methods.
  • I also specified the dtype of diffsize in the state returned by NewtonChord.step, this was needed to pass tests with complex-valued inputs. There, specifying the dtype in init only was not enough.

@johannahaffner johannahaffner merged commit c487d56 into tidy-dev Aug 13, 2025
2 checks passed
@johannahaffner
Copy link
Collaborator

And merged! Thanks for the fix :)

@patrick-kidger patrick-kidger deleted the patrick/dtype-newton branch August 14, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants